You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/04 17:43:32 UTC

[GitHub] [spark] wangyum opened a new pull request #25351: [SPARK-28614][SQL][TEST] Do not remove leading write space in the golden result file

wangyum opened a new pull request #25351: [SPARK-28614][SQL][TEST] Do not remove leading write space in the golden result file
URL: https://github.com/apache/spark/pull/25351
 
 
   ## What changes were proposed in this pull request?
   
   It's hard to know if the query needs to be sorted like [`SQLQueryTestSuite.isSorted`](https://github.com/apache/spark/blob/2ecc39c8d346437811fa991dc6471dc6862eb1f2/sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala#L375-L380) when building a test framework for Thriftserver. So we  can sort both  the `outputs` and  the `expectedOutputs. However, we removed leading write space in the golden result file. This can lead to inconsistent results.
   This PR makes it does not remove leading write space in the golden result file. Trailing write space still needs to be removed.
   
   
   ## How was this patch tested?
   
   N/A
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org