You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Munendra S N (JIRA)" <ji...@apache.org> on 2017/12/15 17:02:00 UTC
[jira] [Commented] (SOLR-11758) Missing boolVal implementation in
FloatDocValues
[ https://issues.apache.org/jira/browse/SOLR-11758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292817#comment-16292817 ]
Munendra S N commented on SOLR-11758:
-------------------------------------
Adding further details to explain the need for this.
I wanted to boost some documents by fixed value if they match some condition
{code:java}
if(and(query($qq1),query($qq2)),500,0)
{code}
Here, problem was that even when document matched these condition it was not getting boosted. Even though query($qq1) and query($qq2) both returned non-zero positive values (both values were < 1).
In this case, I could have also used *exists* which would solve but I wanted to know the reason for such behavior.
On debugging, I found that *FloatDocValues* which is base class for *QueryDocValues* doesn't implement *boolVal* method, hence, *boolVal* of *FunctionValues* is called.
Ideally, *FloatDocValues* should have an implementation to override boolValue like how it is done in *DoubleDocValues*.
> Missing boolVal implementation in FloatDocValues
> ------------------------------------------------
>
> Key: SOLR-11758
> URL: https://issues.apache.org/jira/browse/SOLR-11758
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Munendra S N
> Priority: Minor
> Attachments: SOLR-11758.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> In case of *DoubleDocValues*, *boolVal(int doc)* has been implemented but this is missing in case *FloatDocValues*.
> *Impact*: For any DocValues which extends *FloatDocValues* and doesn't implement *boolVal(int doc)*, parent *boolVal* in FucntionValues would be called.
> boolVal implementation in FunctionValues
> {code:java}
> @Override
> public boolean boolVal(int doc) throws IOException {
> return intVal(doc) != 0;
> }
> {code}
> Let me know if I can work on it
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org