[Bug 6700] URI Rule Type appears to fire on headers and it shouldn't...

[bu...@bugzilla.spamassassin.org]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6700

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Kevin A. McGrail <km...@pccc.com> ---
Based on discussion, I removed the code that extracts URI from the DKIM
signatures.

Index: lib/Mail/SpamAssassin/PerMsgStatus.pm
===================================================================
--- lib/Mail/SpamAssassin/PerMsgStatus.pm       (revision 1429128)
+++ lib/Mail/SpamAssassin/PerMsgStatus.pm       (working copy)
@@ -1989,14 +1989,19 @@
   # do this so we're sure metadata->html is setup
   my %parsed = map { $_ => 'parsed' } $self->_get_parsed_uri_list();

+
+  # This parses of DKIM for URIs disagrees with documentation and bug 6700
votes to disable
+  # this functionality
+  # 2013-01-07
+
   # Look for the domain in DK/DKIM headers
-  my $dk = join(" ", grep {defined} ( $self->get('DomainKey-Signature',undef),
-                                      $self->get('DKIM-Signature',undef) ));
-  while ($dk =~ /\bd\s*=\s*([^;]+)/g) {
-    my $dom = $1;
-    $dom =~ s/\s+//g;
-    $parsed{$dom} = 'domainkeys';
-  }
+  #my $dk = join(" ", grep {defined} (
$self->get('DomainKey-Signature',undef),
+  #                                    $self->get('DKIM-Signature',undef) ));
+  #while ($dk =~ /\bd\s*=\s*([^;]+)/g) {
+  #  my $dom = $1;
+  #  $dom =~ s/\s+//g;
+  #  $parsed{$dom} = 'domainkeys';
+  #}

   # get URIs from HTML parsing
   # use the metadata version since $self->{html} may not be setup

svn commit -m 'Disabled parsing of DKIM Header to extract URIs - Bug 6700'
lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending        lib/Mail/SpamAssassin/PerMsgStatus.pm
Transmitting file data .
Committed revision 1429988.

-- 
You are receiving this mail because:
You are the assignee for the bug.