You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Arun Patidar (JIRA)" <ji...@apache.org> on 2009/11/23 12:55:39 UTC
[jira] Created: (OFBIZ-3249) Shopping cart on checkout page does
not gets update when a gift item is added in cart after applying coupon
code.
Shopping cart on checkout page does not gets update when a gift item is added in cart after applying coupon code.
------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-3249
URL: https://issues.apache.org/jira/browse/OFBIZ-3249
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Reporter: Arun Patidar
Priority: Minor
Fix For: Release Branch 4.0, Release Branch 9.04
For a coupon code on which a gift item is added in cart, shopping cart on checkout page does not gets update for that new added gift item.
Currently cart is only updating for discounted amount.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3249) Shopping cart on checkout page does
not gets update when a gift item is added in cart after applying coupon
code.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781389#action_12781389 ]
Ashish Vijaywargiya commented on OFBIZ-3249:
--------------------------------------------
Arun, have you tested it on release branch 9.04?
--
Ashish
> Shopping cart on checkout page does not gets update when a gift item is added in cart after applying coupon code.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3249
> URL: https://issues.apache.org/jira/browse/OFBIZ-3249
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3249.patch
>
>
> For a coupon code on which a gift item is added in cart, shopping cart on checkout page does not gets update for that new added gift item.
> Currently cart is only updating for discounted amount.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3249) Shopping cart on checkout page does
not gets update when a gift item is added in cart after applying coupon
code.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781398#action_12781398 ]
Ashish Vijaywargiya commented on OFBIZ-3249:
--------------------------------------------
Yes this makes perfect sense to me, Arun (Thanks!).
Man please don't do guess :-) - lot of people are using release branch 9.04 keeping in mind that it is stable.
Before two day I have committed code for shopping cart changes in release branch keeping in mind that it might have been tested / reviewed by developer. Then I saw the release branch was broken due to my changes and a new mail in my Inbox for reporting this issue (Thanks Scott for reporting the issue). I have only cross checked things for trunk but now I would prefer to keep myself active for release branch changes as well before committing any changes in it.
Arun & others please help me and other committers to test / review things on release branch before mentioning that it is ready for release branch and this bug exists in release branch.
Thanks Arun for your contribution. I will wait till morning, if your patch is not picked up by someone else then I will take care of it.
--
Ashish Vijaywargiya
> Shopping cart on checkout page does not gets update when a gift item is added in cart after applying coupon code.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3249
> URL: https://issues.apache.org/jira/browse/OFBIZ-3249
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3249.patch
>
>
> For a coupon code on which a gift item is added in cart, shopping cart on checkout page does not gets update for that new added gift item.
> Currently cart is only updating for discounted amount.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3249) Shopping cart on checkout page does
not gets update when a gift item is added in cart after applying coupon
code.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781381#action_12781381 ]
Ashish Vijaywargiya commented on OFBIZ-3249:
--------------------------------------------
Arun - Is this bug exists only in release branch 4 & 9.04?
--
Ashish
> Shopping cart on checkout page does not gets update when a gift item is added in cart after applying coupon code.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3249
> URL: https://issues.apache.org/jira/browse/OFBIZ-3249
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: Release Branch 4.0, Release Branch 9.04
>
> Attachments: OFBIZ-3249.patch
>
>
> For a coupon code on which a gift item is added in cart, shopping cart on checkout page does not gets update for that new added gift item.
> Currently cart is only updating for discounted amount.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3249) Shopping cart on checkout page does
not gets update when a gift item is added in cart after applying coupon
code.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Patidar updated OFBIZ-3249:
--------------------------------
Attachment: OFBIZ-3249.patch
Here is patch for update cart on one page checkout page when a gift item a added in cart after applying valid coupon code.
Steps to test:
1. Create a new product promo for 'Gift With Purchase' action with require coupon code.
2. Go to ecommerce -> main
3. Purchase X product and go for one page checkout page.
4. Enter coupon code
5 If this coupon code is valid according to condition given in promotion then a you will get Y product as gift in cart with 0.0 price.
> Shopping cart on checkout page does not gets update when a gift item is added in cart after applying coupon code.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3249
> URL: https://issues.apache.org/jira/browse/OFBIZ-3249
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: Release Branch 4.0, Release Branch 9.04
>
> Attachments: OFBIZ-3249.patch
>
>
> For a coupon code on which a gift item is added in cart, shopping cart on checkout page does not gets update for that new added gift item.
> Currently cart is only updating for discounted amount.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3249) Shopping cart on checkout page does
not gets update when a gift item is added in cart after applying coupon
code.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Patidar updated OFBIZ-3249:
--------------------------------
Fix Version/s: (was: Release Branch 9.04)
Ashish,
Thanks Ashish for taking care of this. I have not tested it on 9.04 but this issue is very old so It was my guess only. Now I am updating this issue only for trunk, I will test it on 9.04 and if it exists there then I will create new issue for that.
---
Arun
> Shopping cart on checkout page does not gets update when a gift item is added in cart after applying coupon code.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3249
> URL: https://issues.apache.org/jira/browse/OFBIZ-3249
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3249.patch
>
>
> For a coupon code on which a gift item is added in cart, shopping cart on checkout page does not gets update for that new added gift item.
> Currently cart is only updating for discounted amount.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3249) Shopping cart on checkout page does
not gets update when a gift item is added in cart after applying coupon
code.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781403#action_12781403 ]
Jacques Le Roux commented on OFBIZ-3249:
----------------------------------------
Thanks for that comment Ashish,
We all know it's not always easy to test all cases, and sometimes there are side-effects. Anyway, i agree this should not prevent us to take care as much as possible.
Thanks for you help
> Shopping cart on checkout page does not gets update when a gift item is added in cart after applying coupon code.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3249
> URL: https://issues.apache.org/jira/browse/OFBIZ-3249
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3249.patch
>
>
> For a coupon code on which a gift item is added in cart, shopping cart on checkout page does not gets update for that new added gift item.
> Currently cart is only updating for discounted amount.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3249) Shopping cart on checkout page does not
gets update when a gift item is added in cart after applying coupon code.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya closed OFBIZ-3249.
--------------------------------------
Resolution: Fixed
Thanks Arun for the contribution - Done at r885425.
--
Ashish
> Shopping cart on checkout page does not gets update when a gift item is added in cart after applying coupon code.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3249
> URL: https://issues.apache.org/jira/browse/OFBIZ-3249
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Arun Patidar
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3249.patch
>
>
> For a coupon code on which a gift item is added in cart, shopping cart on checkout page does not gets update for that new added gift item.
> Currently cart is only updating for discounted amount.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3249) Shopping cart on checkout page does
not gets update when a gift item is added in cart after applying coupon
code.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-3249:
------------------------------------------
Assignee: Ashish Vijaywargiya
> Shopping cart on checkout page does not gets update when a gift item is added in cart after applying coupon code.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3249
> URL: https://issues.apache.org/jira/browse/OFBIZ-3249
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Arun Patidar
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3249.patch
>
>
> For a coupon code on which a gift item is added in cart, shopping cart on checkout page does not gets update for that new added gift item.
> Currently cart is only updating for discounted amount.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3249) Shopping cart on checkout page does
not gets update when a gift item is added in cart after applying coupon
code.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Patidar updated OFBIZ-3249:
--------------------------------
Fix Version/s: (was: Release Branch 4.0)
SVN trunk
Ashish - Its by mistake. This bug should be exists in 9.04 and trunk only.
> Shopping cart on checkout page does not gets update when a gift item is added in cart after applying coupon code.
> ------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3249
> URL: https://issues.apache.org/jira/browse/OFBIZ-3249
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3249.patch
>
>
> For a coupon code on which a gift item is added in cart, shopping cart on checkout page does not gets update for that new added gift item.
> Currently cart is only updating for discounted amount.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.