You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/10/21 05:59:20 UTC
[GitHub] zeppelin pull request #1546: [ Hotfix ] Incorrect (per user) setup ui for "c...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1546
[ Hotfix ] Incorrect (per user) setup ui for "create new interpreter component"
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
Bug Fix
### Todos
- [x] fix to text margin top
- [x] implement to (per note / per user) setup feature of create new insterpreter
### How should this be tested?
1. on click interpreter menu.
2. on click interpreter menu.
3. check per user and per note setting. (`per user` setting must be shiro is activated)
4. save and check to result.
### Screenshots (if appropriate)
#### - Create new Interpreter - before

#### - Create new Interpreter - after

#### - fix margin for interpreter settings - before

#### - fix margin for interpreter settings - after

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin hotfix-inerpreterRunningModeUIFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1546
----
commit ebf1d811c7e6b34cf5af85ef5a2a2f6d1b9b2910
Author: CloverHearts <cl...@gmail.com>
Date: 2016-10-21T05:40:01Z
hotfix - change setup ui for interpreter setting components
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1546: [ Hotfix ] Incorrect (per user) setup ui for "create n...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1546
LGTM. I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1546: [ Hotfix ] Incorrect (per user) setup ui for "c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1546: [ Hotfix ] Incorrect (per user) setup ui for "c...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1546: [ Hotfix ] Incorrect (per user) setup ui for "create n...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1546
@jongyoul
could you please review for this pr?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1546: [ Hotfix ] Incorrect (per user) setup ui for "c...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1546
[ Hotfix ] Incorrect (per user) setup ui for "create new interpreter component"
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
Bug Fix
### Todos
- [x] fix to text margin top
- [x] implement to (per note / per user) setup feature of create new insterpreter
### How should this be tested?
1. on click interpreter menu.
2. on click interpreter menu.
3. check per user and per note setting. (`per user` setting must be shiro is activated)
4. save and check to result.
### Screenshots (if appropriate)
#### - Create new Interpreter - before

#### - Create new Interpreter - after

#### - fix margin for interpreter settings - before

#### - fix margin for interpreter settings - after

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin hotfix-inerpreterRunningModeUIFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1546
----
commit ebf1d811c7e6b34cf5af85ef5a2a2f6d1b9b2910
Author: CloverHearts <cl...@gmail.com>
Date: 2016-10-21T05:40:01Z
hotfix - change setup ui for interpreter setting components
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---