You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Timothy Braun (JIRA)" <de...@myfaces.apache.org> on 2007/09/17 20:28:43 UTC

[jira] Created: (MYFACES-1728) JspViewHandler improperly flushing writer

JspViewHandler improperly flushing writer
-----------------------------------------

                 Key: MYFACES-1728
                 URL: https://issues.apache.org/jira/browse/MYFACES-1728
             Project: MyFaces Core
          Issue Type: Bug
    Affects Versions:  1.2.0
            Reporter: Timothy Braun


The JspViewHandler is improperly flushing the writer.  It makes a call to endDocument after it flushes it the writer, which leaves part of the document stuck in the buffer.  I have a patch to fix this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (MYFACES-1728) JspViewHandler improperly flushing writer

Posted by "Timothy Braun (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timothy Braun updated MYFACES-1728:
-----------------------------------

    Status: Patch Available  (was: Open)

> JspViewHandler improperly flushing writer
> -----------------------------------------
>
>                 Key: MYFACES-1728
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1728
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions:  1.2.0
>            Reporter: Timothy Braun
>
> The JspViewHandler is improperly flushing the writer.  It makes a call to endDocument after it flushes it the writer, which leaves part of the document stuck in the buffer.  I have a patch to fix this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (MYFACES-1728) JspViewHandler improperly flushing writer

Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Marinschek updated MYFACES-1728:
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.1-SNAPSHOT
         Assignee: Martin Marinschek
           Status: Resolved  (was: Patch Available)

I'm for now resolving this - we'll reopen if there are still problems.

regards,

Martin

> JspViewHandler improperly flushing writer
> -----------------------------------------
>
>                 Key: MYFACES-1728
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1728
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions:  1.2.0
>            Reporter: Timothy Braun
>            Assignee: Martin Marinschek
>             Fix For: 1.2.1-SNAPSHOT
>
>         Attachments: JspViewHandler.patch
>
>
> The JspViewHandler is improperly flushing the writer.  It makes a call to endDocument after it flushes it the writer, which leaves part of the document stuck in the buffer.  I have a patch to fix this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (MYFACES-1728) JspViewHandler improperly flushing writer

Posted by "Timothy Braun (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528110 ] 

Timothy Braun commented on MYFACES-1728:
----------------------------------------

I apologize, I typed JspViewHandler, but I meant org.apache.myfaces.application.jsp.JspViewHandlerImpl

> JspViewHandler improperly flushing writer
> -----------------------------------------
>
>                 Key: MYFACES-1728
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1728
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions:  1.2.0
>            Reporter: Timothy Braun
>         Attachments: JspViewHandler.patch
>
>
> The JspViewHandler is improperly flushing the writer.  It makes a call to endDocument after it flushes it the writer, which leaves part of the document stuck in the buffer.  I have a patch to fix this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (MYFACES-1728) JspViewHandler improperly flushing writer

Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530924 ] 

Martin Marinschek commented on MYFACES-1728:
--------------------------------------------

I've applied your patch - actually moved the line myself, the patch didn't want to apply - but also refactored most of the renderView-method. The current implementation was - hmm, how do I put it? - strange to my eyes. I hope it is better now. I've tried the sample apps, they work fine now, can you give my changes a ride and then we close this out?

regards,

Martin

> JspViewHandler improperly flushing writer
> -----------------------------------------
>
>                 Key: MYFACES-1728
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1728
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions:  1.2.0
>            Reporter: Timothy Braun
>         Attachments: JspViewHandler.patch
>
>
> The JspViewHandler is improperly flushing the writer.  It makes a call to endDocument after it flushes it the writer, which leaves part of the document stuck in the buffer.  I have a patch to fix this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.