You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Bayer <no...@github.com> on 2013/07/02 02:35:05 UTC
[jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api classes.
(#51)
You can merge this Pull Request by running:
git pull https://github.com/abayer/jclouds-1 jclouds-150-for-1.6.x
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/51
-- Commit Summary --
* JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api classes.
-- File Changes --
M apis/ec2/src/main/java/org/jclouds/ec2/EC2Api.java (77)
M apis/ec2/src/main/java/org/jclouds/ec2/EC2ApiMetadata.java (5)
M apis/ec2/src/main/java/org/jclouds/ec2/EC2AsyncApi.java (77)
M apis/ec2/src/main/java/org/jclouds/ec2/EC2Client.java (4)
M apis/ec2/src/main/java/org/jclouds/ec2/config/EC2RestClientModule.java (21)
A apis/ec2/src/main/java/org/jclouds/ec2/features/AMIApi.java (39)
A apis/ec2/src/main/java/org/jclouds/ec2/features/AMIAsyncApi.java (44)
A apis/ec2/src/main/java/org/jclouds/ec2/features/AvailabilityZoneAndRegionApi.java (39)
A apis/ec2/src/main/java/org/jclouds/ec2/features/AvailabilityZoneAndRegionAsyncApi.java (44)
A apis/ec2/src/main/java/org/jclouds/ec2/features/ElasticBlockStoreApi.java (39)
A apis/ec2/src/main/java/org/jclouds/ec2/features/ElasticBlockStoreAsyncApi.java (44)
A apis/ec2/src/main/java/org/jclouds/ec2/features/ElasticIPAddressApi.java (39)
A apis/ec2/src/main/java/org/jclouds/ec2/features/ElasticIPAddressAsyncApi.java (44)
A apis/ec2/src/main/java/org/jclouds/ec2/features/InstanceApi.java (39)
A apis/ec2/src/main/java/org/jclouds/ec2/features/InstanceAsyncApi.java (44)
A apis/ec2/src/main/java/org/jclouds/ec2/features/KeyPairApi.java (39)
A apis/ec2/src/main/java/org/jclouds/ec2/features/KeyPairAsyncApi.java (44)
A apis/ec2/src/main/java/org/jclouds/ec2/features/SecurityGroupApi.java (39)
A apis/ec2/src/main/java/org/jclouds/ec2/features/SecurityGroupAsyncApi.java (44)
M apis/ec2/src/main/java/org/jclouds/ec2/features/WindowsApi.java (3)
M apis/ec2/src/main/java/org/jclouds/ec2/features/WindowsAsyncApi.java (3)
M apis/ec2/src/main/java/org/jclouds/ec2/services/AMIAsyncClient.java (2)
M apis/ec2/src/main/java/org/jclouds/ec2/services/AMIClient.java (4)
M apis/ec2/src/main/java/org/jclouds/ec2/services/AvailabilityZoneAndRegionAsyncClient.java (3)
M apis/ec2/src/main/java/org/jclouds/ec2/services/AvailabilityZoneAndRegionClient.java (2)
M apis/ec2/src/main/java/org/jclouds/ec2/services/ElasticBlockStoreAsyncClient.java (3)
M apis/ec2/src/main/java/org/jclouds/ec2/services/ElasticBlockStoreClient.java (2)
M apis/ec2/src/main/java/org/jclouds/ec2/services/ElasticIPAddressAsyncClient.java (3)
M apis/ec2/src/main/java/org/jclouds/ec2/services/ElasticIPAddressClient.java (2)
M apis/ec2/src/main/java/org/jclouds/ec2/services/InstanceAsyncClient.java (3)
M apis/ec2/src/main/java/org/jclouds/ec2/services/InstanceClient.java (2)
M apis/ec2/src/main/java/org/jclouds/ec2/services/KeyPairAsyncClient.java (3)
M apis/ec2/src/main/java/org/jclouds/ec2/services/KeyPairClient.java (2)
M apis/ec2/src/main/java/org/jclouds/ec2/services/SecurityGroupAsyncClient.java (3)
M apis/ec2/src/main/java/org/jclouds/ec2/services/SecurityGroupClient.java (2)
M apis/ec2/src/main/java/org/jclouds/ec2/services/WindowsAsyncClient.java (3)
M apis/ec2/src/main/java/org/jclouds/ec2/services/WindowsClient.java (2)
A apis/openstack-nova-ec2/src/main/java/org/jclouds/openstack/nova/ec2/NovaEC2Api.java (47)
A apis/openstack-nova-ec2/src/main/java/org/jclouds/openstack/nova/ec2/NovaEC2AsyncApi.java (49)
M apis/openstack-nova-ec2/src/main/java/org/jclouds/openstack/nova/ec2/NovaEC2Client.java (2)
M apis/openstack-nova-ec2/src/main/java/org/jclouds/openstack/nova/ec2/config/NovaEC2RestClientModule.java (25)
A apis/openstack-nova-ec2/src/main/java/org/jclouds/openstack/nova/ec2/features/NovaEC2KeyPairApi.java (48)
A apis/openstack-nova-ec2/src/main/java/org/jclouds/openstack/nova/ec2/features/NovaEC2KeyPairAsyncApi.java (50)
M apis/openstack-nova-ec2/src/main/java/org/jclouds/openstack/nova/ec2/services/NovaEC2KeyPairAsyncClient.java (3)
M apis/openstack-nova-ec2/src/main/java/org/jclouds/openstack/nova/ec2/services/NovaEC2KeyPairClient.java (2)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/AWSEC2Api.java (120)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/AWSEC2AsyncApi.java (120)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/AWSEC2Client.java (2)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/config/AWSEC2RestClientModule.java (40)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/AWSAMIApi.java (49)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/AWSAMIAsyncApi.java (51)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/AWSInstanceApi.java (49)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/AWSInstanceAsyncApi.java (51)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/AWSKeyPairApi.java (49)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/AWSKeyPairAsyncApi.java (51)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/AWSSecurityGroupApi.java (49)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/AWSSecurityGroupAsyncApi.java (51)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/MonitoringApi.java (48)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/MonitoringAsyncApi.java (50)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/PlacementGroupApi.java (48)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/PlacementGroupAsyncApi.java (50)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/SpotInstanceApi.java (48)
A providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/features/SpotInstanceAsyncApi.java (50)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/AWSAMIAsyncClient.java (3)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/AWSAMIClient.java (2)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/AWSInstanceAsyncClient.java (3)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/AWSInstanceClient.java (2)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/AWSKeyPairAsyncClient.java (3)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/AWSKeyPairClient.java (2)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/AWSSecurityGroupAsyncClient.java (3)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/AWSSecurityGroupClient.java (2)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/MonitoringAsyncClient.java (3)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/MonitoringClient.java (2)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/PlacementGroupAsyncClient.java (3)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/PlacementGroupClient.java (2)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/SpotInstanceAsyncClient.java (3)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/services/SpotInstanceClient.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/51.patch
https://github.com/jclouds/jclouds/pull/51.diff
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #31](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/31/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20359608
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #488](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/488/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20321478
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by Andrew Bayer <no...@github.com>.
@everett-toews - how does " * Note that this class is transitionary and will fully replace its parent in 1.7." in the javadoc sound for the *Api classes?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20321205
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #28](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/28/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20321474
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by Everett Toews <no...@github.com>.
> @@ -88,6 +102,13 @@
> .put(WindowsApi.class, WindowsAsyncApi.class)//
> .put(TagApi.class, TagAsyncApi.class)//
> .put(SubnetApi.class, SubnetAsyncApi.class)//
> + .put(AMIApi.class, AMIAsyncApi.class)//
> + .put(AvailabilityZoneAndRegionApi.class, AvailabilityZoneAndRegionAsyncApi.class)//
> + .put(ElasticBlockStoreApi.class, ElasticBlockStoreAsyncApi.class)//
> + .put(ElasticIPAddressApi.class, ElasticIPAddressAsyncApi.class)//
> + .put(InstanceApi.class, InstanceAsyncApi.class)//
> + .put(KeyPairApi.class, KeyPairAsyncApi.class)//
> + .put(SecurityGroupApi.class, SecurityGroupAsyncApi.class)//
What's with the weird empty comments at the end of each of these puts? Can you get rid of them?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51/files#r4975872
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by Andrew Bayer <no...@github.com>.
> @@ -88,6 +102,13 @@
> .put(WindowsApi.class, WindowsAsyncApi.class)//
> .put(TagApi.class, TagAsyncApi.class)//
> .put(SubnetApi.class, SubnetAsyncApi.class)//
> + .put(AMIApi.class, AMIAsyncApi.class)//
> + .put(AvailabilityZoneAndRegionApi.class, AvailabilityZoneAndRegionAsyncApi.class)//
> + .put(ElasticBlockStoreApi.class, ElasticBlockStoreAsyncApi.class)//
> + .put(ElasticIPAddressApi.class, ElasticIPAddressAsyncApi.class)//
> + .put(InstanceApi.class, InstanceAsyncApi.class)//
> + .put(KeyPairApi.class, KeyPairAsyncApi.class)//
> + .put(SecurityGroupApi.class, SecurityGroupAsyncApi.class)//
No idea. They were there when I got here, as it were.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51/files#r4976030
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #489](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/489/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20323252
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #491](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/491/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20359517
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #157](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/157/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20359390
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by Everett Toews <no...@github.com>.
Other than that minor stuff.
+1!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20320677
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #29](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/29/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20322090
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by Everett Toews <no...@github.com>.
Those empty comments are in a few classes. Can you clean them up everywhere?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20320558
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by Everett Toews <no...@github.com>.
I understand why you had the *Api classes extend the *Client classes. It might not be obvious to a user though. I think you need a brief comment in the *Api class Javadoc to say that they're only extending the *Client class until the *Client class is removed (and the code gets copied over).
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20320659
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #155](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/155/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20323155
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #154](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/154/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20321128
Re: [jclouds] JCLOUDS-150. Deprecate EC2 *Client, add dummy *Api
classes. (#51)
Posted by Everett Toews <no...@github.com>.
Works for me.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/51#issuecomment-20321251