You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Violeta Georgieva <mi...@gmail.com> on 2014/06/20 21:59:16 UTC

Time for 7.0.55

Hi,

I would like to start preparing Tomcat 7.0.55 for voting this weekend.
If you want to include something in addition to this release, reply here.

Regards
Violeta

Re: Time for 7.0.55

Posted by Andrew Carr <an...@gmail.com>.
Thanks Violeta


On Fri, Jul 18, 2014 at 7:57 AM, Violeta Georgieva <mi...@gmail.com>
wrote:

> Hi,
>
>
> 2014-07-18 8:08 GMT+03:00 Andrew Carr <an...@gmail.com>:
> >
> > Hi Konstantin,
> >
> > Since you are going on vacation, should we not expect 7.0.55 until some
> > point after you return?
>
> As Konstantin already wrote all known issues with Mapper are fixed.
> I'm starting with tagging.
>
> Regards,
> Violeta
>
> >
> > Thank you very much for your answer.
> > Andrew
> >
> >
> >
> >
> > On Thu, Jul 10, 2014 at 5:30 PM, Konstantin Kolinko <
> knst.kolinko@gmail.com>
> > wrote:
> >
> > > 2014-07-11 1:05 GMT+04:00 Violeta Georgieva <mi...@gmail.com>:
> > > > Hi,
> > > >
> > > > I'm receiving the following exception:
> > > >
> > > >      [exec]     [junit] Jul 10, 2014 11:33:16 PM
> > > > org.apache.coyote.http11.AbstractHttp11Processor process
> > > >      [exec]     [junit] SEVERE: Error processing request
> > > >      [exec]     [junit] java.lang.ArrayIndexOutOfBoundsException: -1
> > > >      [exec]     [junit]         at
> > > >
> org.apache.tomcat.util.http.mapper.Mapper.internalMap(Mapper.java:785)
> > >
> > > The line Mapper.java:785 in 7.0.x is
> > >
> > > "contextVersion = contextVersions[versionCount - 1];"
> > >
> > > so "versionCount" which is equal to "contextVersions.length" is 0.
> > >
> > > Actually I supposed that contextVersions array always has at least one
> > > element.
> > >
> > > There is a bug in Mapper.removeContextVersion().
> > > 326: if (context.versions.length == 0) {
> > >
> > > The line was supposed to be "if (newContextVersions.length == 0)".
> > > This explains the zero-length array.
> > >
> > > Best regards,
> > > Konstantin Kolinko
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > > For additional commands, e-mail: dev-help@tomcat.apache.org
> > >
> > >
> >
> >
> > --
> > With Regards,
> > Andrew Carr
> >
> > e. andrewlanecarr@gmail.com
> > w. andrew.carr@openlogic.com
> > h. 4235255668
> > c. 4239489852
> > a. 101 Francis Drive, Greeneville, TN, 37743
>



-- 
With Regards,
Andrew Carr

e. andrewlanecarr@gmail.com
w. andrew.carr@openlogic.com
h. 4235255668
c. 4239489852
a. 101 Francis Drive, Greeneville, TN, 37743

Re: Time for 7.0.55

Posted by Violeta Georgieva <mi...@gmail.com>.
Hi,


2014-07-18 8:08 GMT+03:00 Andrew Carr <an...@gmail.com>:
>
> Hi Konstantin,
>
> Since you are going on vacation, should we not expect 7.0.55 until some
> point after you return?

As Konstantin already wrote all known issues with Mapper are fixed.
I'm starting with tagging.

Regards,
Violeta

>
> Thank you very much for your answer.
> Andrew
>
>
>
>
> On Thu, Jul 10, 2014 at 5:30 PM, Konstantin Kolinko <
knst.kolinko@gmail.com>
> wrote:
>
> > 2014-07-11 1:05 GMT+04:00 Violeta Georgieva <mi...@gmail.com>:
> > > Hi,
> > >
> > > I'm receiving the following exception:
> > >
> > >      [exec]     [junit] Jul 10, 2014 11:33:16 PM
> > > org.apache.coyote.http11.AbstractHttp11Processor process
> > >      [exec]     [junit] SEVERE: Error processing request
> > >      [exec]     [junit] java.lang.ArrayIndexOutOfBoundsException: -1
> > >      [exec]     [junit]         at
> > > org.apache.tomcat.util.http.mapper.Mapper.internalMap(Mapper.java:785)
> >
> > The line Mapper.java:785 in 7.0.x is
> >
> > "contextVersion = contextVersions[versionCount - 1];"
> >
> > so "versionCount" which is equal to "contextVersions.length" is 0.
> >
> > Actually I supposed that contextVersions array always has at least one
> > element.
> >
> > There is a bug in Mapper.removeContextVersion().
> > 326: if (context.versions.length == 0) {
> >
> > The line was supposed to be "if (newContextVersions.length == 0)".
> > This explains the zero-length array.
> >
> > Best regards,
> > Konstantin Kolinko
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
> >
>
>
> --
> With Regards,
> Andrew Carr
>
> e. andrewlanecarr@gmail.com
> w. andrew.carr@openlogic.com
> h. 4235255668
> c. 4239489852
> a. 101 Francis Drive, Greeneville, TN, 37743

Re: Time for 7.0.55

Posted by Andrew Carr <an...@gmail.com>.
Hi Konstantin,

Since you are going on vacation, should we not expect 7.0.55 until some
point after you return?

Thank you very much for your answer.
Andrew




On Thu, Jul 10, 2014 at 5:30 PM, Konstantin Kolinko <kn...@gmail.com>
wrote:

> 2014-07-11 1:05 GMT+04:00 Violeta Georgieva <mi...@gmail.com>:
> > Hi,
> >
> > I'm receiving the following exception:
> >
> >      [exec]     [junit] Jul 10, 2014 11:33:16 PM
> > org.apache.coyote.http11.AbstractHttp11Processor process
> >      [exec]     [junit] SEVERE: Error processing request
> >      [exec]     [junit] java.lang.ArrayIndexOutOfBoundsException: -1
> >      [exec]     [junit]         at
> > org.apache.tomcat.util.http.mapper.Mapper.internalMap(Mapper.java:785)
>
> The line Mapper.java:785 in 7.0.x is
>
> "contextVersion = contextVersions[versionCount - 1];"
>
> so "versionCount" which is equal to "contextVersions.length" is 0.
>
> Actually I supposed that contextVersions array always has at least one
> element.
>
> There is a bug in Mapper.removeContextVersion().
> 326: if (context.versions.length == 0) {
>
> The line was supposed to be "if (newContextVersions.length == 0)".
> This explains the zero-length array.
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


-- 
With Regards,
Andrew Carr

e. andrewlanecarr@gmail.com
w. andrew.carr@openlogic.com
h. 4235255668
c. 4239489852
a. 101 Francis Drive, Greeneville, TN, 37743

Re: Time for 7.0.55

Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-07-11 1:05 GMT+04:00 Violeta Georgieva <mi...@gmail.com>:
> Hi,
>
> I'm receiving the following exception:
>
>      [exec]     [junit] Jul 10, 2014 11:33:16 PM
> org.apache.coyote.http11.AbstractHttp11Processor process
>      [exec]     [junit] SEVERE: Error processing request
>      [exec]     [junit] java.lang.ArrayIndexOutOfBoundsException: -1
>      [exec]     [junit]         at
> org.apache.tomcat.util.http.mapper.Mapper.internalMap(Mapper.java:785)

The line Mapper.java:785 in 7.0.x is

"contextVersion = contextVersions[versionCount - 1];"

so "versionCount" which is equal to "contextVersions.length" is 0.

Actually I supposed that contextVersions array always has at least one element.

There is a bug in Mapper.removeContextVersion().
326: if (context.versions.length == 0) {

The line was supposed to be "if (newContextVersions.length == 0)".
This explains the zero-length array.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Time for 7.0.55

Posted by Violeta Georgieva <mi...@gmail.com>.
Hi,


2014-07-09 21:10 GMT+03:00 Violeta Georgieva <mi...@gmail.com>:
>
>
> Hi,
>
> 2014-07-09 17:35 GMT+03:00 Konstantin Kolinko <kn...@gmail.com>:
>
> >
> > 2014-07-09 6:39 GMT+04:00 Konstantin Kolinko <kn...@gmail.com>:
> > > 2014-07-08 13:45 GMT+04:00 Konstantin Kolinko <knst.kolinko@gmail.com
>:
> > >> 2014-07-08 13:17 GMT+04:00 Mark Thomas <ma...@apache.org>:
> > >>> On 27/06/2014 17:20, Konstantin Kolinko wrote:
> > >>>> 2014-06-27 18:16 GMT+04:00 Mark Thomas <ma...@apache.org>:
> > >>>>> On 23/06/2014 14:00, Violeta Georgieva wrote:
> > >>>>>> 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko
> > >>>> Mapper issues:
> > >>>> BZ 44312: Fixed. Proposed for 6.0.
> > >>>>
> > >>>> BZ 56653: Fix re-implemented in Tomcat 8 to be less intrusive.
> > >>>> Not backported.
> > >>>> I backported testcase for it (r1604846), but neither Gump nor
Testbot
> > >>>> fail with it.
> > >>>>
> > >>>> BZ 56658: Not started.
> > >>>>
> > >>>> I plan to work on Mapper tonight and tomorrow.
> > >>>
> > >>> Any progress on this? Looking at Bugzilla, these are the only open
> > >>> issues for 7.0.x and I assume we want to resolve them before a
7.0.55 tag.
> > >>
> > >> All are fixed in Tomcat 8 a week ago.
> > >>
> > >> I shall backport 56653, 56658 to Tomcat 7 today.
> > >>
> > >
> > > Issue 56653 fixed. This leaves 56658.
> >
> > Issue 56658 fixed.
> >
> > Mapper issues fixed.  I did run testsuite with NIO connector - all OK.
> >
> > I think we are OK to go with a release.
>
> Thanks a lot.
> I'll start the tagging tomorrow.

I'm receiving the following exception:

     [exec]     [junit] Jul 10, 2014 11:33:16 PM
org.apache.coyote.http11.AbstractHttp11Processor process
     [exec]     [junit] SEVERE: Error processing request
     [exec]     [junit] java.lang.ArrayIndexOutOfBoundsException: -1
     [exec]     [junit]         at
org.apache.tomcat.util.http.mapper.Mapper.internalMap(Mapper.java:785)
     [exec]     [junit]         at
org.apache.tomcat.util.http.mapper.Mapper.map(Mapper.java:662)
     [exec]     [junit]         at
org.apache.catalina.connector.CoyoteAdapter.postParseRequest(CoyoteAdapter.java:714)
     [exec]     [junit]         at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:403)
     [exec]     [junit]         at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1070)
     [exec]     [junit]         at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:611)
     [exec]     [junit]         at
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:314)
     [exec]     [junit]         at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
     [exec]     [junit]         at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
     [exec]     [junit]         at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
     [exec]     [junit]         at java.lang.Thread.run(Thread.java:662)

The following "quick" patch fixes the problem:

Index: C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java
===================================================================
--- C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java (revision
1609565)
+++ C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java (working
copy)
@@ -779,18 +779,21 @@
             if (version != null) {
                 contextVersion = exactFind(contextVersions, version);
             }
+            if (contextVersion == null) {
+                // Return the latest version
+                contextVersion = contextVersions[versionCount - 1];
+            }
+        } else if (versionCount == 1) {
+            contextVersion = contextVersions[0];
         }
-        if (contextVersion == null) {
-            // Return the latest version
-            contextVersion = contextVersions[versionCount - 1];
+
+        if (contextVersion != null) {
+            mappingData.context = contextVersion.object;
+            mappingData.contextSlashCount = contextVersion.slashCount;
+            // Wrapper mapping
+            internalMapWrapper(contextVersion, uri, mappingData);
         }

-        mappingData.context = contextVersion.object;
-        mappingData.contextSlashCount = contextVersion.slashCount;
-
-        // Wrapper mapping
-        internalMapWrapper(contextVersion, uri, mappingData);
-
     }




>
> Regards,
> Violeta
>
> >
> > Best regards,
> > Konstantin Kolinko
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >

Re: Time for 7.0.55

Posted by Violeta Georgieva <mi...@gmail.com>.
Hi,

2014-07-09 17:35 GMT+03:00 Konstantin Kolinko <kn...@gmail.com>:
>
> 2014-07-09 6:39 GMT+04:00 Konstantin Kolinko <kn...@gmail.com>:
> > 2014-07-08 13:45 GMT+04:00 Konstantin Kolinko <kn...@gmail.com>:
> >> 2014-07-08 13:17 GMT+04:00 Mark Thomas <ma...@apache.org>:
> >>> On 27/06/2014 17:20, Konstantin Kolinko wrote:
> >>>> 2014-06-27 18:16 GMT+04:00 Mark Thomas <ma...@apache.org>:
> >>>>> On 23/06/2014 14:00, Violeta Georgieva wrote:
> >>>>>> 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko
> >>>> Mapper issues:
> >>>> BZ 44312: Fixed. Proposed for 6.0.
> >>>>
> >>>> BZ 56653: Fix re-implemented in Tomcat 8 to be less intrusive.
> >>>> Not backported.
> >>>> I backported testcase for it (r1604846), but neither Gump nor Testbot
> >>>> fail with it.
> >>>>
> >>>> BZ 56658: Not started.
> >>>>
> >>>> I plan to work on Mapper tonight and tomorrow.
> >>>
> >>> Any progress on this? Looking at Bugzilla, these are the only open
> >>> issues for 7.0.x and I assume we want to resolve them before a 7.0.55
tag.
> >>
> >> All are fixed in Tomcat 8 a week ago.
> >>
> >> I shall backport 56653, 56658 to Tomcat 7 today.
> >>
> >
> > Issue 56653 fixed. This leaves 56658.
>
> Issue 56658 fixed.
>
> Mapper issues fixed.  I did run testsuite with NIO connector - all OK.
>
> I think we are OK to go with a release.

Thanks a lot.
I'll start the tagging tomorrow.

Regards,
Violeta

>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

Re: Time for 7.0.55

Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-07-09 6:39 GMT+04:00 Konstantin Kolinko <kn...@gmail.com>:
> 2014-07-08 13:45 GMT+04:00 Konstantin Kolinko <kn...@gmail.com>:
>> 2014-07-08 13:17 GMT+04:00 Mark Thomas <ma...@apache.org>:
>>> On 27/06/2014 17:20, Konstantin Kolinko wrote:
>>>> 2014-06-27 18:16 GMT+04:00 Mark Thomas <ma...@apache.org>:
>>>>> On 23/06/2014 14:00, Violeta Georgieva wrote:
>>>>>> 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko
>>>> Mapper issues:
>>>> BZ 44312: Fixed. Proposed for 6.0.
>>>>
>>>> BZ 56653: Fix re-implemented in Tomcat 8 to be less intrusive.
>>>> Not backported.
>>>> I backported testcase for it (r1604846), but neither Gump nor Testbot
>>>> fail with it.
>>>>
>>>> BZ 56658: Not started.
>>>>
>>>> I plan to work on Mapper tonight and tomorrow.
>>>
>>> Any progress on this? Looking at Bugzilla, these are the only open
>>> issues for 7.0.x and I assume we want to resolve them before a 7.0.55 tag.
>>
>> All are fixed in Tomcat 8 a week ago.
>>
>> I shall backport 56653, 56658 to Tomcat 7 today.
>>
>
> Issue 56653 fixed. This leaves 56658.

Issue 56658 fixed.

Mapper issues fixed.  I did run testsuite with NIO connector - all OK.

I think we are OK to go with a release.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Time for 7.0.55

Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-07-08 13:45 GMT+04:00 Konstantin Kolinko <kn...@gmail.com>:
> 2014-07-08 13:17 GMT+04:00 Mark Thomas <ma...@apache.org>:
>> On 27/06/2014 17:20, Konstantin Kolinko wrote:
>>> 2014-06-27 18:16 GMT+04:00 Mark Thomas <ma...@apache.org>:
>>>> On 23/06/2014 14:00, Violeta Georgieva wrote:
>>>>> 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko
>>> Mapper issues:
>>> BZ 44312: Fixed. Proposed for 6.0.
>>>
>>> BZ 56653: Fix re-implemented in Tomcat 8 to be less intrusive.
>>> Not backported.
>>> I backported testcase for it (r1604846), but neither Gump nor Testbot
>>> fail with it.
>>>
>>> BZ 56658: Not started.
>>>
>>> I plan to work on Mapper tonight and tomorrow.
>>
>> Any progress on this? Looking at Bugzilla, these are the only open
>> issues for 7.0.x and I assume we want to resolve them before a 7.0.55 tag.
>
> All are fixed in Tomcat 8 a week ago.
>
> I shall backport 56653, 56658 to Tomcat 7 today.
>

Issue 56653 fixed. This leaves 56658.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Time for 7.0.55

Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-07-08 13:17 GMT+04:00 Mark Thomas <ma...@apache.org>:
> On 27/06/2014 17:20, Konstantin Kolinko wrote:
>> 2014-06-27 18:16 GMT+04:00 Mark Thomas <ma...@apache.org>:
>>> On 23/06/2014 14:00, Violeta Georgieva wrote:
>>>> 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko
>> Mapper issues:
>> BZ 44312: Fixed. Proposed for 6.0.
>>
>> BZ 56653: Fix re-implemented in Tomcat 8 to be less intrusive.
>> Not backported.
>> I backported testcase for it (r1604846), but neither Gump nor Testbot
>> fail with it.
>>
>> BZ 56658: Not started.
>>
>> I plan to work on Mapper tonight and tomorrow.
>
> Any progress on this? Looking at Bugzilla, these are the only open
> issues for 7.0.x and I assume we want to resolve them before a 7.0.55 tag.

All are fixed in Tomcat 8 a week ago.

I shall backport 56653, 56658 to Tomcat 7 today.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Time for 7.0.55

Posted by Mark Thomas <ma...@apache.org>.
On 27/06/2014 17:20, Konstantin Kolinko wrote:
> 2014-06-27 18:16 GMT+04:00 Mark Thomas <ma...@apache.org>:
>> On 23/06/2014 14:00, Violeta Georgieva wrote:
>>> 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko <kn...@gmail.com>:
>>>>
>>>> 2014-06-20 23:59 GMT+04:00 Violeta Georgieva <mi...@gmail.com>:
>>>>> Hi,
>>>>>
>>>>> I would like to start preparing Tomcat 7.0.55 for voting this weekend.
>>>>> If you want to include something in addition to this release, reply
>>> here.
>>>>>
>>>>
>>>> Hi!
>>>>
>>>> The Mapper issues are taking longer than I anticipated, and I expect
>>>> myself to be busy on the start of next week.  It is impeded by
>>>> implementation differences (Tomcat 7 has two mappers: in Connector and
>>>> in Context, Tomcat 8 has one).
>>>>
>>>> I would like to backport fixes for 56653 and 56658 to Tomcat 7  (the
>>>> latter has not been fixed in trunk yet) along with other improvements.
>>>>
>>>> I expect that fixing those issues requires changing internal classes
>>>> of Mapper like I did in r1604319.  I think that we are OK with such
>>>> change, as those are our internal APIs.
>>>>
>>>>
>>>> The Tomcat-Native binaries for Windows are linked to an old version of
>>>> OpenSSL that has known security issues.  Christopher has not yet
>>>> succeeded in building it.
>>>
>>> Ok I'll wait for you and Chris.
>>> Meanwhile the new JDT compiler will be officially released (Luna release -
>>> 25.06) and we may include it in 7.0.55.
>>
>> I know we are still waiting for the fixed Windows binaries. What is the
>> status of the remaining work?
> 
> Mapper issues:
> BZ 44312: Fixed. Proposed for 6.0.
> 
> BZ 56653: Fix re-implemented in Tomcat 8 to be less intrusive.
> Not backported.
> I backported testcase for it (r1604846), but neither Gump nor Testbot
> fail with it.
> 
> BZ 56658: Not started.
> 
> I plan to work on Mapper tonight and tomorrow.

Any progress on this? Looking at Bugzilla, these are the only open
issues for 7.0.x and I assume we want to resolve them before a 7.0.55 tag.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Time for 7.0.55

Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-06-27 18:16 GMT+04:00 Mark Thomas <ma...@apache.org>:
> On 23/06/2014 14:00, Violeta Georgieva wrote:
>> 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko <kn...@gmail.com>:
>>>
>>> 2014-06-20 23:59 GMT+04:00 Violeta Georgieva <mi...@gmail.com>:
>>>> Hi,
>>>>
>>>> I would like to start preparing Tomcat 7.0.55 for voting this weekend.
>>>> If you want to include something in addition to this release, reply
>> here.
>>>>
>>>
>>> Hi!
>>>
>>> The Mapper issues are taking longer than I anticipated, and I expect
>>> myself to be busy on the start of next week.  It is impeded by
>>> implementation differences (Tomcat 7 has two mappers: in Connector and
>>> in Context, Tomcat 8 has one).
>>>
>>> I would like to backport fixes for 56653 and 56658 to Tomcat 7  (the
>>> latter has not been fixed in trunk yet) along with other improvements.
>>>
>>> I expect that fixing those issues requires changing internal classes
>>> of Mapper like I did in r1604319.  I think that we are OK with such
>>> change, as those are our internal APIs.
>>>
>>>
>>> The Tomcat-Native binaries for Windows are linked to an old version of
>>> OpenSSL that has known security issues.  Christopher has not yet
>>> succeeded in building it.
>>
>> Ok I'll wait for you and Chris.
>> Meanwhile the new JDT compiler will be officially released (Luna release -
>> 25.06) and we may include it in 7.0.55.
>
> I know we are still waiting for the fixed Windows binaries. What is the
> status of the remaining work?

Mapper issues:
BZ 44312: Fixed. Proposed for 6.0.

BZ 56653: Fix re-implemented in Tomcat 8 to be less intrusive.
Not backported.
I backported testcase for it (r1604846), but neither Gump nor Testbot
fail with it.

BZ 56658: Not started.

I plan to work on Mapper tonight and tomorrow.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Time for 7.0.55

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,

On 6/27/14, 10:16 AM, Mark Thomas wrote:
>> Ok I'll wait for you and Chris.
>> Meanwhile the new JDT compiler will be officially released (Luna release -
>> 25.06) and we may include it in 7.0.55.
> 
> I know we are still waiting for the fixed Windows binaries. What is the
> status of the remaining work?

I'm stuck and need some help from someone who understands the build
process better. I don't see myself making any progress alone.

Any volunteers?

-chris


Re: Time for 7.0.55

Posted by Mark Thomas <ma...@apache.org>.
On 23/06/2014 14:00, Violeta Georgieva wrote:
> 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko <kn...@gmail.com>:
>>
>> 2014-06-20 23:59 GMT+04:00 Violeta Georgieva <mi...@gmail.com>:
>>> Hi,
>>>
>>> I would like to start preparing Tomcat 7.0.55 for voting this weekend.
>>> If you want to include something in addition to this release, reply
> here.
>>>
>>
>> Hi!
>>
>> The Mapper issues are taking longer than I anticipated, and I expect
>> myself to be busy on the start of next week.  It is impeded by
>> implementation differences (Tomcat 7 has two mappers: in Connector and
>> in Context, Tomcat 8 has one).
>>
>> I would like to backport fixes for 56653 and 56658 to Tomcat 7  (the
>> latter has not been fixed in trunk yet) along with other improvements.
>>
>> I expect that fixing those issues requires changing internal classes
>> of Mapper like I did in r1604319.  I think that we are OK with such
>> change, as those are our internal APIs.
>>
>>
>> The Tomcat-Native binaries for Windows are linked to an old version of
>> OpenSSL that has known security issues.  Christopher has not yet
>> succeeded in building it.
> 
> Ok I'll wait for you and Chris.
> Meanwhile the new JDT compiler will be officially released (Luna release -
> 25.06) and we may include it in 7.0.55.

I know we are still waiting for the fixed Windows binaries. What is the
status of the remaining work?

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Time for 7.0.55

Posted by Violeta Georgieva <mi...@gmail.com>.
2014-06-22 21:33 GMT+03:00 Konstantin Kolinko <kn...@gmail.com>:
>
> 2014-06-20 23:59 GMT+04:00 Violeta Georgieva <mi...@gmail.com>:
> > Hi,
> >
> > I would like to start preparing Tomcat 7.0.55 for voting this weekend.
> > If you want to include something in addition to this release, reply
here.
> >
>
> Hi!
>
> The Mapper issues are taking longer than I anticipated, and I expect
> myself to be busy on the start of next week.  It is impeded by
> implementation differences (Tomcat 7 has two mappers: in Connector and
> in Context, Tomcat 8 has one).
>
> I would like to backport fixes for 56653 and 56658 to Tomcat 7  (the
> latter has not been fixed in trunk yet) along with other improvements.
>
> I expect that fixing those issues requires changing internal classes
> of Mapper like I did in r1604319.  I think that we are OK with such
> change, as those are our internal APIs.
>
>
> The Tomcat-Native binaries for Windows are linked to an old version of
> OpenSSL that has known security issues.  Christopher has not yet
> succeeded in building it.

Ok I'll wait for you and Chris.
Meanwhile the new JDT compiler will be officially released (Luna release -
25.06) and we may include it in 7.0.55.

>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

Re: Time for 7.0.55

Posted by Konstantin Kolinko <kn...@gmail.com>.
2014-06-20 23:59 GMT+04:00 Violeta Georgieva <mi...@gmail.com>:
> Hi,
>
> I would like to start preparing Tomcat 7.0.55 for voting this weekend.
> If you want to include something in addition to this release, reply here.
>

Hi!

The Mapper issues are taking longer than I anticipated, and I expect
myself to be busy on the start of next week.  It is impeded by
implementation differences (Tomcat 7 has two mappers: in Connector and
in Context, Tomcat 8 has one).

I would like to backport fixes for 56653 and 56658 to Tomcat 7  (the
latter has not been fixed in trunk yet) along with other improvements.

I expect that fixing those issues requires changing internal classes
of Mapper like I did in r1604319.  I think that we are OK with such
change, as those are our internal APIs.


The Tomcat-Native binaries for Windows are linked to an old version of
OpenSSL that has known security issues.  Christopher has not yet
succeeded in building it.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org