You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/02 06:35:32 UTC

[GitHub] [cloudstack-primate] utchoang opened a new pull request #784: Confirmation by pressing Space on confirm screens

utchoang opened a new pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784


   Fixes #781 
   @rhtyd cc @svenvogel 
   Please review it. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #784: Confirmation by pressing Space on confirm screens

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #784: Confirmation by pressing Space on confirm screens

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784#issuecomment-703397739


   @utchoang I think what @borisstoyanov meant was that hitting space toggles the value of the first button / checkbox / switch. An autofocus on the first form item would be an appropriate fix


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #784: Confirmation by pressing Space on confirm screens

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784#issuecomment-703454163


   @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #784: Confirmation by pressing Space on confirm screens

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784#issuecomment-702554922


   @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on pull request #784: Confirmation by pressing Space on confirm screens

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784#issuecomment-702554637


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #784: Confirmation by pressing Space on confirm screens

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784#issuecomment-703458289


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/784 (JID-3560)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on pull request #784: Confirmation by pressing Space on confirm screens

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784#issuecomment-703391861


   @rhtyd I think it won't cause a regression. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #784: Confirmation by pressing Space on confirm screens

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784#issuecomment-703388588


   Good to have, could this cause any regressions? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #784: Confirmation by pressing Space on confirm screens

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784#issuecomment-702558006


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/784 (JID-3555)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on pull request #784: Confirmation by pressing Space on confirm screens

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #784:
URL: https://github.com/apache/cloudstack-primate/pull/784#issuecomment-703453584


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org