You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by Zhixiong Chen <zh...@kyligence.io> on 2018/02/04 13:42:15 UTC
Re: 答复: 答复: 答复: Can't delete segment
Thanks Cheng
There is a jira already.
https://issues.apache.org/jira/browse/KYLIN-3215
I will merge this patch recently.
Thanks!
Zhixiong Chen
From: 张 佑铖 <ed...@hotmail.com>
Reply-To: "dev@kylin.apache.org" <de...@kylin.apache.org>
Date: Sunday, 4 February 2018 at 9:25 PM
To: "dev@kylin.apache.org" <de...@kylin.apache.org>
Subject: 答复: 答复: 答复: Can't delete segment
Thank you Shaofeng,
Actually I have checked the code in master, the function dropJob has been improved already, with commit 8191b8ed39c32d8cfa30eaa596c03552db736a70
[cid:17efd413-3b20-46e0-9c07-3e51d3fc7606]
before delete job, check if exist relatedCube, if exist throw badrequestexception.
Maybe just one little improvement, for the web, do not show "drop" when the job status is 'ERROR'
________________________________
发件人: ShaoFeng Shi <sh...@apache.org>
发送时间: 2018年2月4日 21:11
收件人: dev
主题: Re: 答复: 答复: Can't delete segment
Cool! Git patch is welcomed. You can generate the patch by following the
guide here: https://kylin.apache.org/development/howto_contribute.html
2018-02-04 19:01 GMT+08:00 张 佑铖 <ed...@hotmail.com>:
>
> You mean a patch for github ?
> I am very pleased to do it.
> I haven't done it before, but I will try it these few days. Why not
>
> I also met other problems, I will write another mail to start.
>
>
> ________________________________
> 发件人: ShaoFeng Shi <sh...@apache.org>
> 发送时间: 2018年2月2日 22:01
> 收件人: dev
> 主题: Re: 答复: Can't delete segment
>
> Thank you You Cheng; And if you want to contribute a patch, that is
> welcomed!
>
> 2018-02-02 21:29 GMT+08:00 张 佑铖 <ed...@hotmail.com>:
>
> > 1. KYLIN-3228<https://issues.apache.org/jira/browse/KYLIN-3228> has
> > been created.
> > 2.
> > *
> >
> > ________________________________
> > 发件人: ShaoFeng Shi <sh...@apache.org>
> > 发送时间: 2018年2月2日 19:02
> > 收件人: dev
> > 主题: Re: Can't delete segment
> >
> > Hi yousheng, it looks be a bug; when deleting a job, it should remove the
> > related segment. Could you please report a JIRA?
> >
> > Next time, you don't need to purge the cube; you can backup the metadata
> to
> > disk, edit the cube json manually, and then restore it.
> >
> > 2018-02-02 18:29 GMT+08:00 张 佑铖 <ed...@hotmail.com>:
> >
> > > Hi kylin team,
> > >
> > > After a job been error, I click drop instead of discard by mistake, I
> > > can't find the job anywhere, but it still remain an empty segment in
> > cube.
> > > When I call restful request /{cubeName}/segs/{segmentName} it returns
> > > Cannot delete segment '' as its status is not READY. Discard the
> on-going
> > > job for it
> > > So it turn out to be a dilemma for, I can't build/refresh the segment,
> > and
> > > I can't delete either.
> > > Finally I purge the cube...
> > > I wonder if it is a bug or there is some solutions?
> > >
> > >
> > > version 2.2.0
> > >
> > >
> > > thanks
> > >
> > >
> >
> >
> > --
> > Best regards,
> >
> > Shaofeng Shi 史少锋
> >
>
>
>
> --
> Best regards,
>
> Shaofeng Shi 史少锋
>
--
Best regards,
Shaofeng Shi 史少锋
Re: 答复: 答复: 答复: Can't delete segment
Posted by ShaoFeng Shi <sh...@apache.org>.
Thanks Zhixiong and Youcheng's information, then I marked this Jira as
duplicated. Thanks!
2018-02-04 21:42 GMT+08:00 Zhixiong Chen <zh...@kyligence.io>:
> Thanks Cheng
> There is a jira already.
> https://issues.apache.org/jira/browse/KYLIN-3215
> I will merge this patch recently.
>
> Thanks!
> Zhixiong Chen
>
> From: 张 佑铖 <ed...@hotmail.com>
> Reply-To: "dev@kylin.apache.org" <de...@kylin.apache.org>
> Date: Sunday, 4 February 2018 at 9:25 PM
> To: "dev@kylin.apache.org" <de...@kylin.apache.org>
> Subject: 答复: 答复: 答复: Can't delete segment
>
> Thank you Shaofeng,
>
> Actually I have checked the code in master, the function dropJob has been
> improved already, with commit 8191b8ed39c32d8cfa30eaa596c03552db736a70
> [cid:17efd413-3b20-46e0-9c07-3e51d3fc7606]
> before delete job, check if exist relatedCube, if exist throw
> badrequestexception.
>
> Maybe just one little improvement, for the web, do not show "drop" when
> the job status is 'ERROR'
>
>
>
> ________________________________
> 发件人: ShaoFeng Shi <sh...@apache.org>
> 发送时间: 2018年2月4日 21:11
> 收件人: dev
> 主题: Re: 答复: 答复: Can't delete segment
>
> Cool! Git patch is welcomed. You can generate the patch by following the
> guide here: https://kylin.apache.org/development/howto_contribute.html
>
> 2018-02-04 19:01 GMT+08:00 张 佑铖 <ed...@hotmail.com>:
>
> >
> > You mean a patch for github ?
> > I am very pleased to do it.
> > I haven't done it before, but I will try it these few days. Why not
> >
> > I also met other problems, I will write another mail to start.
> >
> >
> > ________________________________
> > 发件人: ShaoFeng Shi <sh...@apache.org>
> > 发送时间: 2018年2月2日 22:01
> > 收件人: dev
> > 主题: Re: 答复: Can't delete segment
> >
> > Thank you You Cheng; And if you want to contribute a patch, that is
> > welcomed!
> >
> > 2018-02-02 21:29 GMT+08:00 张 佑铖 <ed...@hotmail.com>:
> >
> > > 1. KYLIN-3228<https://issues.apache.org/jira/browse/KYLIN-3228> has
> > > been created.
> > > 2.
> > > *
> > >
> > > ________________________________
> > > 发件人: ShaoFeng Shi <sh...@apache.org>
> > > 发送时间: 2018年2月2日 19:02
> > > 收件人: dev
> > > 主题: Re: Can't delete segment
> > >
> > > Hi yousheng, it looks be a bug; when deleting a job, it should remove
> the
> > > related segment. Could you please report a JIRA?
> > >
> > > Next time, you don't need to purge the cube; you can backup the
> metadata
> > to
> > > disk, edit the cube json manually, and then restore it.
> > >
> > > 2018-02-02 18:29 GMT+08:00 张 佑铖 <ed...@hotmail.com>:
> > >
> > > > Hi kylin team,
> > > >
> > > > After a job been error, I click drop instead of discard by mistake,
> I
> > > > can't find the job anywhere, but it still remain an empty segment in
> > > cube.
> > > > When I call restful request /{cubeName}/segs/{segmentName} it
> returns
> > > > Cannot delete segment '' as its status is not READY. Discard the
> > on-going
> > > > job for it
> > > > So it turn out to be a dilemma for, I can't build/refresh the
> segment,
> > > and
> > > > I can't delete either.
> > > > Finally I purge the cube...
> > > > I wonder if it is a bug or there is some solutions?
> > > >
> > > >
> > > > version 2.2.0
> > > >
> > > >
> > > > thanks
> > > >
> > > >
> > >
> > >
> > > --
> > > Best regards,
> > >
> > > Shaofeng Shi 史少锋
> > >
> >
> >
> >
> > --
> > Best regards,
> >
> > Shaofeng Shi 史少锋
> >
>
>
>
> --
> Best regards,
>
> Shaofeng Shi 史少锋
>
--
Best regards,
Shaofeng Shi 史少锋