You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <ji...@apache.org> on 2010/05/13 17:56:42 UTC
[jira] Created: (DERBY-4657) Allow functions to return BOOLEAN
values
Allow functions to return BOOLEAN values
----------------------------------------
Key: DERBY-4657
URL: https://issues.apache.org/jira/browse/DERBY-4657
Project: Derby
Issue Type: Improvement
Components: SQL
Reporter: Rick Hillegas
As part of our expanding support for the BOOLEAN datatype, it would be nice to allow functions to return BOOLEAN values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4657) Allow functions to return BOOLEAN
values
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-4657:
---------------------------------
Issue & fix info: [Patch Available]
> Allow functions to return BOOLEAN values
> ----------------------------------------
>
> Key: DERBY-4657
> URL: https://issues.apache.org/jira/browse/DERBY-4657
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4657-01-aa-booleanReturnValues.diff, derby-4657-01-ab-booleanReturnValues.diff
>
>
> As part of our expanding support for the BOOLEAN datatype, it would be nice to allow functions to return BOOLEAN values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4657) Allow functions to return BOOLEAN
values
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-4657:
---------------------------------
Attachment: derby-4657-01-aa-booleanReturnValues.diff
Attaching derby-4657-01-aa-booleanReturnValues.diff. This allows functions to return BOOLEAN return values. Regression tests passed cleanly for me.
Touches the following files:
----------
M java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
Allows functions to be declared with BOOLEAN return values. BOOLEAN is still not allowed as an argument or column type or as the target type in an explicit CAST.
----------
M java/engine/org/apache/derby/impl/sql/compile/MethodCallNode.java
BOOLEAN is added to the list of JDBC types which have both primitive and wrapper Java correspondences.
----------
M java/testing/org/apache/derbyTesting/functionTests/tests/lang/AnsiSignaturesTest.java
M java/testing/org/apache/derbyTesting/functionTests/tests/lang/AnsiSignatures.java
Some unit tests verifying the correct resolution of BOOLEAN valued functions.
> Allow functions to return BOOLEAN values
> ----------------------------------------
>
> Key: DERBY-4657
> URL: https://issues.apache.org/jira/browse/DERBY-4657
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4657-01-aa-booleanReturnValues.diff
>
>
> As part of our expanding support for the BOOLEAN datatype, it would be nice to allow functions to return BOOLEAN values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DERBY-4657) Allow functions to return
BOOLEAN values
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867623#action_12867623 ]
Rick Hillegas edited comment on DERBY-4657 at 5/14/10 2:53 PM:
---------------------------------------------------------------
The regression tests ran cleanly for me on derby-4657-01-ab-booleanReturnValues.diff. Committed at subversion revision 944386.
was (Author: rhillegas):
The regression tests ran cleanly for me on derby-4657-01-ab-booleanReturnValues.diff.
> Allow functions to return BOOLEAN values
> ----------------------------------------
>
> Key: DERBY-4657
> URL: https://issues.apache.org/jira/browse/DERBY-4657
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4657-01-aa-booleanReturnValues.diff, derby-4657-01-ab-booleanReturnValues.diff
>
>
> As part of our expanding support for the BOOLEAN datatype, it would be nice to allow functions to return BOOLEAN values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4657) Allow functions to return BOOLEAN
values
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867623#action_12867623 ]
Rick Hillegas commented on DERBY-4657:
--------------------------------------
The regression tests ran cleanly for me on derby-4657-01-ab-booleanReturnValues.diff.
> Allow functions to return BOOLEAN values
> ----------------------------------------
>
> Key: DERBY-4657
> URL: https://issues.apache.org/jira/browse/DERBY-4657
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4657-01-aa-booleanReturnValues.diff, derby-4657-01-ab-booleanReturnValues.diff
>
>
> As part of our expanding support for the BOOLEAN datatype, it would be nice to allow functions to return BOOLEAN values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4657) Allow functions to return BOOLEAN
values
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-4657:
---------------------------------
Attachment: derby-4657-01-ab-booleanReturnValues.diff
Attaching derby-4657-01-ab-booleanReturnValues.diff. This second rev of the patch adds upgrade support. I am running the regression tests now. If the tests pass, then I believe the patch is ready to be committed.
This feature should only be available in databases created at 10.7 or hard-upgraded to 10.7. Since this is the first 10.7 feature with upgrade implications, this patch incurs the tax of creating the upgrade machinery for 10.7.
I successfully ran the upgrade tests using the following set of initial releases:
10.0.2.1
10.1.1.0
10.1.2.1
10.1.3.1
10.2.1.6
10.2.2.0
10.2.2.1
10.3.1.4
10.3.2.1
10.3.3.0
10.4.1.3
10.4.2.0
10.4.2.1
10.5.1.1
10.5.2.0
10.5.3.0
10.6.1.0
I ran out of perm gen space with MaxPermSize set to 256. The following settings allowed the upgrade tests to complete successfully:
-XX:MaxPermSize=512M -Xmx1024m
Touches the following files in addition to those touched by the first rev:
----------
M java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java
M java/engine/org/apache/derby/impl/sql/catalog/DD_Version.java
M java/engine/org/apache/derby/iapi/sql/dictionary/DataDictionary.java
Upgrade machinery for 10.7.
----------
A java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/Changes10_7.java
M java/testing/org/apache/derbyTesting/functionTests/tests/upgradeTests/UpgradeRun.java
First test case for 10.7 upgrade.
> Allow functions to return BOOLEAN values
> ----------------------------------------
>
> Key: DERBY-4657
> URL: https://issues.apache.org/jira/browse/DERBY-4657
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4657-01-aa-booleanReturnValues.diff, derby-4657-01-ab-booleanReturnValues.diff
>
>
> As part of our expanding support for the BOOLEAN datatype, it would be nice to allow functions to return BOOLEAN values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-4657) Allow functions to return BOOLEAN
values
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas closed DERBY-4657.
--------------------------------
Resolution: Fixed
> Allow functions to return BOOLEAN values
> ----------------------------------------
>
> Key: DERBY-4657
> URL: https://issues.apache.org/jira/browse/DERBY-4657
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4657-01-aa-booleanReturnValues.diff, derby-4657-01-ab-booleanReturnValues.diff
>
>
> As part of our expanding support for the BOOLEAN datatype, it would be nice to allow functions to return BOOLEAN values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-4657) Allow functions to return BOOLEAN
values
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas reassigned DERBY-4657:
------------------------------------
Assignee: Rick Hillegas
> Allow functions to return BOOLEAN values
> ----------------------------------------
>
> Key: DERBY-4657
> URL: https://issues.apache.org/jira/browse/DERBY-4657
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
>
> As part of our expanding support for the BOOLEAN datatype, it would be nice to allow functions to return BOOLEAN values.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.