You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2017/02/12 18:41:41 UTC

[jira] [Commented] (VALIDATOR-416) CreditCardValidator default ctor disagrees with Javadoc

    [ https://issues.apache.org/jira/browse/VALIDATOR-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862906#comment-15862906 ] 

Sebb commented on VALIDATOR-416:
--------------------------------

At the very least the inconsistency should be noted in the Javadoc.

> CreditCardValidator default ctor disagrees with Javadoc
> -------------------------------------------------------
>
>                 Key: VALIDATOR-416
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-416
>             Project: Commons Validator
>          Issue Type: Bug
>    Affects Versions: 1.5.1
>            Reporter: Sebb
>
> The CreditCardValidator class Javadoc says:
> "By default, all supported card types are allowed."
> However the default constructor says it supports:
> AMEX, VISA, MASTERCARD and DISCOVER
> which agrees with the code.
> It looks as though the default constructor was not updated when new validators were added.
> I think it would make more sense to include all the provided validators in the default, but this could be considered a change of behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)