You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by hbdeshmukh <gi...@git.apache.org> on 2016/06/03 20:36:27 UTC
[GitHub] incubator-quickstep pull request #7: Bug fixed in SimpleScalarSeparateChaini...
GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/7
Bug fixed in SimpleScalarSeparateChainingHashTable::isFull()
- Earlier check for isFull() was that whether there is at least one empty bucket available for insertion.
- Now isFull() can check if there is enough space for adding specified number of buckets.
- To reproduce the bug behind this fix: Run TPC-H Q2 on SF100 dataset after
running the \analyze command. The optimizer allocates smaller than
necessary space for one of the hash joins. The resize() is triggered
but never gets executed because of the restrictive isFull() condition.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep simple-scalar-isfull-bugfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit 69c65518ff603081e724be581badffc7efeabead
Author: Harshad Deshmukh <ha...@cs.wisc.edu>
Date: 2016-06-03T20:28:52Z
Bug fixed in isFull() function.
- Earlier check for isFull() was that whether there is at least one
empty bucket available for insertion.
- Now isFull() can check if there is enough space adding specified
number of buckets.
- To reproduce the bug behind this fix: Run TPC-H Q2 on SF100 dataset after
running the \analyze command. The optimizer allocates smaller than
necessary space for one of the hash joins. The resize() is triggered
but never gets executed because of the restrictive isFull() condition.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #7: Bug fixed in SimpleScalarSeparateChaini...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #7: Bug fixed in SimpleScalarSeparateChainingHashT...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/7
@hbdeshmukh @pateljm I've dropped the second commit using the command line. So no worry about that, and use `git rebase -i` for merging new commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #7: Bug fixed in SimpleScalarSeparateChainingHashT...
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/7
@pateljm But the second commit is not related to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #7: Bug fixed in SimpleScalarSeparateChainingHashT...
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/7
Looks good @hbdeshmukh. Merged. I know clang is failing, but that appears to be related to the ongoing LLVM issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-quickstep issue #7: Bug fixed in SimpleScalarSeparateChainingHashT...
Posted by Jignesh Patel <ji...@pivotal.io>.
Intersting that when one comments on a PR the email to this list has the name of the original author of the PR (in this case hbdeshmukh) rather than the person who created the comment. Somewhat misleading.
Any tips on how to fix this?
Cheers,
Jignesh
> On Jun 4, 2016, at 3:55 PM, hbdeshmukh <gi...@git.apache.org> wrote:
>
> Github user hbdeshmukh commented on the issue:
>
> https://github.com/apache/incubator-quickstep/pull/7
>
> @zuyu You are right, and we can undo that if needed. You are also right that in the future, we must be careful to keep PRs focused.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] incubator-quickstep issue #7: Bug fixed in SimpleScalarSeparateChainingHashT...
Posted by hbdeshmukh <gi...@git.apache.org>.
Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/7
@zuyu You are right, and we can undo that if needed. You are also right that in the future, we must be careful to keep PRs focused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---