You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Brian Lachniet (JIRA)" <ji...@apache.org> on 2018/11/03 19:36:00 UTC
[jira] [Commented] (AVRO-2252) I'd like to improve Avro .NET (C#)
library (many points)
[ https://issues.apache.org/jira/browse/AVRO-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674176#comment-16674176 ]
Brian Lachniet commented on AVRO-2252:
--------------------------------------
Some of your concerns have been adressed in [PR #307|https://github.com/apache/avro/pull/307] (AVRO-2112), in addition to many other changes.
* remove unused dependency of log4net library
* replace dependency of json library from direct reference to Nuget package
* make .NET 4.5 and .NET standard 2.0 versions of the library, keeping the existing compatibility with the .NET 3.5 - _we were actually considering dropping support for .NET 3.5, though_
I've had a lot of success using [StyleCop.Analyzers|https://www.nuget.org/packages/stylecop.analyzers/] and [Microsoft.CodeAnalysis.FxCopAnalyzers|https://www.nuget.org/packages/Microsoft.CodeAnalysis.FxCopAnalyzers/2.6.2] to enforce code style conventions in C# projects. I've generally started new projects with these though; I've not taken an old project and introduced these.
> I'd like to improve Avro .NET (C#) library (many points)
> --------------------------------------------------------
>
> Key: AVRO-2252
> URL: https://issues.apache.org/jira/browse/AVRO-2252
> Project: Avro
> Issue Type: Wish
> Components: csharp
> Reporter: Anton Ryzhov
> Priority: Major
>
> Hello all,
> The company where I'm working as a .NET developer is actively using Avro format.
> I'd like to improve Avro .NET (C#) library:
> 1) clean-up the code:
> - remove trailing spaces, unused namespace usings, etc.
> - remove unused dependency of log4net library
> - replace dependency of json library from direct reference to Nuget package
> 2) format the code to unify code style everywhere in the library
> - possibly using the Microsoft recommended code style for C# [https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/inside-a-program/coding-conventions]
> 3) use the latest C# 7.0 language features to make the code more compact and readable
> 4) make .NET 4.5 and .NET standard 2.0 versions of the library, keeping the existing compatibility with the .NET 3.5
> - add asynchronous API to the .NET 4.5 and .NET standard 2.0 versions (async methods along with the synchronous ones).
> What do you think?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)