You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "xyuanlu (via GitHub)" <gi...@apache.org> on 2023/09/21 20:21:11 UTC

[GitHub] [helix] xyuanlu commented on a diff in pull request #2623: Lattice Children Cache Implementation

xyuanlu commented on code in PR #2623:
URL: https://github.com/apache/helix/pull/2623#discussion_r1333562328


##########
meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientCacheInterface.java:
##########
@@ -27,19 +27,29 @@ public interface MetaClientCacheInterface<T> extends MetaClientInterface<T> {
     /**
      * TrieNode class to store the children of the entries to be cached.
      */
-    class TrieNode {
+    public class TrieNode {
         // A mapping between trie key and children nodes.
         private Map<String, TrieNode> _children;
 
         // the complete path/prefix leading to the current node.
         private final String _path;
 
         private final String _nodeKey;
+        private boolean _childrenCached;
 
-        TrieNode(String path, String nodeKey) {
+        public TrieNode(String path, String nodeKey) {
             _path = path;
             _nodeKey = nodeKey;
             _children = new HashMap<>();
+            _childrenCached = false;
+        }
+
+        public boolean isChildrenCached() {

Review Comment:
   Consider AtomicBoolean



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org