You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2025/07/06 23:08:47 UTC
[native-toolchain-CR] Bump Kudu to their 1.18.x branch
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23131
Change subject: Bump Kudu to their 1.18.x branch
......................................................................
Bump Kudu to their 1.18.x branch
Changes the way Kudu JARs are picked up because of a Gradle publishing
problem they are currently investigating
Add the Perl FindBin package to the redhat9 image to support the Kudu
build, which requires it. Red Hat 9 packages Perl 5.32 (or newer),
which split out this package from the main Perl package, so it needs
to be added separately.
Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
---
M buildall.sh
M docker/redhat9.df
M source/kudu/build.sh
3 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/31/23131/1
--
To view, visit http://gerrit.cloudera.org:8080/23131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] Bump Kudu to their 1.18.x branch
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23131 )
Change subject: Bump Kudu to their 1.18.x branch
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23131/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23131/3//COMMIT_MSG@7
PS3, Line 7: Bump Kudu to their 1.18.x branch
Please add a JIRA ticket.
http://gerrit.cloudera.org:8080/#/c/23131/3//COMMIT_MSG@12
PS3, Line 12: Adds the Perl FindBin package to the redhat9 image, required the Kudu
nit: "required by the" (several options would work, just needs a connector)
--
To view, visit http://gerrit.cloudera.org:8080/23131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Aug 2025 16:17:50 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-14394: Bump Kudu to their 1.18.x branch
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23131 )
Change subject: IMPALA-14394: Bump Kudu to their 1.18.x branch
......................................................................
IMPALA-14394: Bump Kudu to their 1.18.x branch
Pick up the most recent release (candidate) from Kudu.
Although Kudu 1.18 is already released, this commit bumps the
toolchain's version of Kudu to a somewhat newer branch, where work is
still in progress.
This is a conscious choice: unfortunately Kudu 1.18 was published with a
Java dependency problem that breaks Impala builds. This problem is fixed
in the currently added state of Kudu's branch-1.18.x, but 1.18.1 is not
published yet, as some OpenSSL-related patches are still being
considered for the 1.18.1 version.
This version already enables a stable Impala build; further Kudu updates
will be imported to the toolchain when the final Kudu 1.18.1 version
becomes available.
This also adds the Perl FindBin package to the redhat9 image, required
by the Kudu build process. Red Hat 9 packages Perl v5.32 (or newer),
which split out this package from the main Perl package, so now it
needs to be added separately.
Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
Reviewed-on: http://gerrit.cloudera.org:8080/23131
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Laszlo Gaal <la...@cloudera.com>
---
M buildall.sh
M docker/redhat9.df
M source/kudu/build.sh
3 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Michael Smith: Looks good to me, approved
Laszlo Gaal: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-14394: Bump Kudu to their 1.18.x branch
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23131
to look at the new patch set (#4).
Change subject: IMPALA-14394: Bump Kudu to their 1.18.x branch
......................................................................
IMPALA-14394: Bump Kudu to their 1.18.x branch
Pick up the most recent release (candidate) from Kudu.
Although Kudu 1.18 is already released, this commit bumps the
toolchain's version of Kudu to a somewhat newer branch, where work is
still in progress.
This is a conscious choice: unfortunately Kudu 1.18 was published with a
Java dependency problem that breaks Impala builds. This problem is fixed
in the currently added state of Kudu's branch-1.18.x, but 1.18.1 is not
published yet, as some OpenSSL-related patches are still being
considered for the 1.18.1 version.
This version already enables a stable Impala build; further Kudu updates
will be imported to the toolchain when the final Kudu 1.18.1 version
becomes available.
This also adds the Perl FindBin package to the redhat9 image, required
by the Kudu build process. Red Hat 9 packages Perl v5.32 (or newer),
which split out this package from the main Perl package, so now it
needs to be added separately.
Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
---
M buildall.sh
M docker/redhat9.df
M source/kudu/build.sh
3 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/31/23131/4
--
To view, visit http://gerrit.cloudera.org:8080/23131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] Bump Kudu to their 1.18.x branch
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/23131 )
Change subject: Bump Kudu to their 1.18.x branch
......................................................................
Bump Kudu to their 1.18.x branch
Changes the way Kudu JARs are archived because of a Gradle publishing
change caused by a Gradle version upgrade in Kudu.
Adds the Perl FindBin package to the redhat9 image, required the Kudu
build process. Red Hat 9 packages Perl v5.32 (or newer), which split
out this package from the main Perl package, so now it needs to be
added separately.
Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
---
M buildall.sh
M docker/redhat9.df
M source/kudu/build.sh
3 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/31/23131/3
--
To view, visit http://gerrit.cloudera.org:8080/23131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
[native-toolchain-CR] IMPALA-14394: Bump Kudu to their 1.18.x branch
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/23131 )
Change subject: IMPALA-14394: Bump Kudu to their 1.18.x branch
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23131/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23131/3//COMMIT_MSG@7
PS3, Line 7: IMPALA-14394: Bump Kudu to their 1.18.x branch
> Please add a JIRA ticket.
Done
http://gerrit.cloudera.org:8080/#/c/23131/3//COMMIT_MSG@12
PS3, Line 12: toolchain's version of Kudu to a somewhat newer branch, where work is
> nit: "required by the" (several options would work, just needs a connector)
Done
--
To view, visit http://gerrit.cloudera.org:8080/23131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Sep 2025 23:25:04 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-14394: Bump Kudu to their 1.18.x branch
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/23131 )
Change subject: IMPALA-14394: Bump Kudu to their 1.18.x branch
......................................................................
Patch Set 4: Verified+1
Both container image builds, and actual toolchain builds have succeeded on private infrastructure
--
To view, visit http://gerrit.cloudera.org:8080/23131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Sep 2025 16:36:30 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-14394: Bump Kudu to their 1.18.x branch
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23131 )
Change subject: IMPALA-14394: Bump Kudu to their 1.18.x branch
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd7b4aed7ed0661d1ac2eaef763c7447f1f09797
Gerrit-Change-Number: 23131
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Sep 2025 23:27:35 +0000
Gerrit-HasComments: No