You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/02/17 20:38:07 UTC
[GitHub] [lucene] jtibshirani opened a new pull request #690: LUCENE-10408: Fix vector valuese iteration bug
jtibshirani opened a new pull request #690:
URL: https://github.com/apache/lucene/pull/690
Now that there is special logic to handle the dense case, we need to adjust some
assertions in VectorValues#advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova commented on a change in pull request #690: LUCENE-10408: Fix vector values iteration bug
Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on a change in pull request #690:
URL: https://github.com/apache/lucene/pull/690#discussion_r809803977
##########
File path: lucene/core/src/java/org/apache/lucene/codecs/lucene91/Lucene91HnswVectorsReader.java
##########
@@ -475,11 +475,10 @@ public int advance(int target) {
}
}
- assert ord <= size;
- if (ord == size) {
- doc = NO_MORE_DOCS;
- } else {
+ if (ord < size) {
Review comment:
Great notice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani merged pull request #690: LUCENE-10408: Fix vector values iteration bug
Posted by GitBox <gi...@apache.org>.
jtibshirani merged pull request #690:
URL: https://github.com/apache/lucene/pull/690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani commented on pull request #690: LUCENE-10408: Fix vector values iteration bug
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #690:
URL: https://github.com/apache/lucene/pull/690#issuecomment-1043407860
This fixes recent test failures in `TestKnnVectorQuery`. One example:
```
./gradlew test --tests TestKnnVectorQuery.testRandomWithFilter -Dtests.seed=1748D2B9616D6A6B
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org