You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/12/20 22:05:31 UTC

[GitHub] [druid] clintropolis opened a new pull request #9085: [Backport] fix vectorized query engine numeric filter matchers against null values

clintropolis opened a new pull request #9085: [Backport] fix vectorized query engine numeric filter matchers against null values
URL: https://github.com/apache/druid/pull/9085
 
 
   Backport of #9063 to 0.17.0-incubating.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jnaous commented on a change in pull request #9085: [Backport] fix vectorized query engine numeric filter matchers against null values

Posted by GitBox <gi...@apache.org>.
jnaous commented on a change in pull request #9085: [Backport] fix vectorized query engine numeric filter matchers against null values
URL: https://github.com/apache/druid/pull/9085#discussion_r360677158
 
 

 ##########
 File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
 ##########
 @@ -2277,8 +2277,6 @@ public void testNullEmptyStringEquality() throws Exception
   @Test
   public void testNullLongFilter() throws Exception
   {
-    // bug https://github.com/apache/incubator-druid/issues/9062 prevents this test from passing
-    skipVectorize();
 
 Review comment:
   Should we look for any uses of the this and see evaluate if they should be removed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] jon-wei merged pull request #9085: [Backport] fix vectorized query engine numeric filter matchers against null values

Posted by GitBox <gi...@apache.org>.
jon-wei merged pull request #9085: [Backport] fix vectorized query engine numeric filter matchers against null values
URL: https://github.com/apache/druid/pull/9085
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org