You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/02 14:28:54 UTC

[GitHub] [airflow] kaxil opened a new pull request #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

kaxil opened a new pull request #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002
 
 
   The following DAG currently fails:
   
   Schema Validation error when DAG.is_paused_upon_creation is set
   
   ```python
   def make_simple_dag():
       """Make very simple DAG to verify serialization result."""
       dag = DAG(
           dag_id='simple_dag',
           default_args={
               "retries": 1,
               "retry_delay": timedelta(minutes=5),
               "depends_on_past": False,
           },
           start_date=datetime(2019, 8, 1),
           is_paused_upon_creation=True,
       )
       BaseOperator(task_id='simple_task', dag=dag, owner='airflow')
       CustomOperator(task_id='custom_task', dag=dag)
       return {'simple_dag': dag}
   ```
   
   **Error**:
   ```
    jsonschema.exceptions.ValidationError: Additional properties are not allowed ('is_paused_upon_creation' was unexpected)
   ```
   
   *Reason*:
   
   `is_paused_upon_creation` is in `DAG.get_serialized_fields()` but not in the Schema definition.
   
   ---
   - [x] Description above provides context of the change
   - [x] Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX) or `[AIRFLOW-XXXX]` for document-only changes
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#discussion_r362554767
 
 

 ##########
 File path: airflow/serialization/json_schema.py
 ##########
 @@ -50,9 +50,9 @@ def iter_errors(self, instance) -> Iterable[jsonschema.exceptions.ValidationErro
         ...
 
 
-def load_dag_schema() -> Validator:
+def load_schema() -> dict:
 
 Review comment:
   ```suggestion
   def load_dag_schema_json() -> dict:
   ```
   
   And then leave the "default" one unchanged as `load_dag_schema`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aa90753cf5f64bf435044cf2e6b81a02fdcf6b33?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7002     +/-   ##
   =========================================
   - Coverage   84.85%   84.55%   -0.3%     
   =========================================
     Files         679      679             
     Lines       38542    38545      +3     
   =========================================
   - Hits        32703    32592    -111     
   - Misses       5839     5953    +114
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <100%> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-1.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [aa90753...3983d24](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aa90753cf5f64bf435044cf2e6b81a02fdcf6b33?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7002     +/-   ##
   =========================================
   - Coverage   84.85%   84.55%   -0.3%     
   =========================================
     Files         679      679             
     Lines       38542    38545      +3     
   =========================================
   - Hits        32703    32592    -111     
   - Misses       5839     5953    +114
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <100%> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-1.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [aa90753...3983d24](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aa90753cf5f64bf435044cf2e6b81a02fdcf6b33?src=pr&el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7002      +/-   ##
   ==========================================
   - Coverage   84.85%   84.57%   -0.28%     
   ==========================================
     Files         679      679              
     Lines       38542    38545       +3     
   ==========================================
   - Hits        32703    32598     -105     
   - Misses       5839     5947     +108
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==) | `85.62% <0%> (-0.6%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
   | [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (+11.42%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [aa90753...1fa2aac](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aa90753cf5f64bf435044cf2e6b81a02fdcf6b33?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7002     +/-   ##
   =========================================
   - Coverage   84.85%   84.55%   -0.3%     
   =========================================
     Files         679      679             
     Lines       38542    38545      +3     
   =========================================
   - Hits        32703    32592    -111     
   - Misses       5839     5953    +114
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <100%> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-1.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [aa90753...3983d24](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aa90753cf5f64bf435044cf2e6b81a02fdcf6b33?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7002     +/-   ##
   =========================================
   - Coverage   84.85%   84.55%   -0.3%     
   =========================================
     Files         679      679             
     Lines       38542    38545      +3     
   =========================================
   - Hits        32703    32592    -111     
   - Misses       5839     5953    +114
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <100%> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-1.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [aa90753...3983d24](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil merged pull request #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aa90753cf5f64bf435044cf2e6b81a02fdcf6b33?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7002     +/-   ##
   =========================================
   - Coverage   84.85%   84.55%   -0.3%     
   =========================================
     Files         679      679             
     Lines       38542    38545      +3     
   =========================================
   - Hits        32703    32592    -111     
   - Misses       5839     5953    +114
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <100%> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-1.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [aa90753...3983d24](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#discussion_r362555526
 
 

 ##########
 File path: airflow/serialization/json_schema.py
 ##########
 @@ -50,9 +50,9 @@ def iter_errors(self, instance) -> Iterable[jsonschema.exceptions.ValidationErro
         ...
 
 
-def load_dag_schema() -> Validator:
+def load_schema() -> dict:
 
 Review comment:
   Done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aa90753cf5f64bf435044cf2e6b81a02fdcf6b33?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7002     +/-   ##
   =========================================
   - Coverage   84.85%   84.55%   -0.3%     
   =========================================
     Files         679      679             
     Lines       38542    38545      +3     
   =========================================
   - Hits        32703    32592    -111     
   - Misses       5839     5953    +114
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <100%> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-1.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [aa90753...3983d24](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/151934cd83ec8a4b9d82d534c3abb190ea3e4f78?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7002     +/-   ##
   =========================================
   - Coverage   84.85%   84.55%   -0.3%     
   =========================================
     Files         679      679             
     Lines       38542    38545      +3     
   =========================================
   - Hits        32703    32592    -111     
   - Misses       5839     5953    +114
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <100%> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-1.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [151934c...3983d24](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aa90753cf5f64bf435044cf2e6b81a02fdcf6b33?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7002     +/-   ##
   =========================================
   - Coverage   84.85%   84.55%   -0.3%     
   =========================================
     Files         679      679             
     Lines       38542    38545      +3     
   =========================================
   - Hits        32703    32592    -111     
   - Misses       5839     5953    +114
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <100%> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-1.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [aa90753...3983d24](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aa90753cf5f64bf435044cf2e6b81a02fdcf6b33?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7002     +/-   ##
   =========================================
   - Coverage   84.85%   84.55%   -0.3%     
   =========================================
     Files         679      679             
     Lines       38542    38545      +3     
   =========================================
   - Hits        32703    32592    -111     
   - Misses       5839     5953    +114
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <100%> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-1.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [aa90753...3983d24](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7002: [AIRFLOW-6425] Serialization: Add missing DAG parameters to Json Schema
URL: https://github.com/apache/airflow/pull/7002#issuecomment-570236002
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=h1) Report
   > Merging [#7002](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/aa90753cf5f64bf435044cf2e6b81a02fdcf6b33?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7002/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7002     +/-   ##
   =========================================
   - Coverage   84.85%   84.55%   -0.3%     
   =========================================
     Files         679      679             
     Lines       38542    38545      +3     
   =========================================
   - Hits        32703    32592    -111     
   - Misses       5839     5953    +114
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.95% <ø> (ø)` | :arrow_up: |
   | [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <100%> (ø)` | :arrow_up: |
   | [airflow/serialization/json\_schema.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2pzb25fc2NoZW1hLnB5) | `84% <100%> (+2.18%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7002/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.72% <0%> (-1.16%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=footer). Last update [aa90753...3983d24](https://codecov.io/gh/apache/airflow/pull/7002?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services