You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/18 17:22:00 UTC
[jira] [Work logged] (KNOX-2131) Fixing bugs found in sonarcloud -
2019 Nov
[ https://issues.apache.org/jira/browse/KNOX-2131?focusedWorklogId=345427&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345427 ]
ASF GitHub Bot logged work on KNOX-2131:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/19 17:21
Start Date: 18/Nov/19 17:21
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #201: KNOX-2131 - Fixed sonarcloud bugs
URL: https://github.com/apache/knox/pull/201
## What changes were proposed in this pull request?
Fixing issues found by `sonarcloud`:
<img width="1415" alt="Screen Shot 2019-11-18 at 5 13 03 PM" src="https://user-images.githubusercontent.com/34065904/69074612-02ce3d80-0a30-11ea-8872-4060284d8de0.png">
## How was this patch tested?
```
mvn clean -Dshellcheck=true -T1C verify -Prelease,package
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:28 min (Wall Clock)
[INFO] Finished at: 2019-11-18T18:20:55+01:00
[INFO] Final Memory: 414M/2435M
[INFO] ------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 345427)
Remaining Estimate: 0h
Time Spent: 10m
> Fixing bugs found in sonarcloud - 2019 Nov
> ------------------------------------------
>
> Key: KNOX-2131
> URL: https://issues.apache.org/jira/browse/KNOX-2131
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.0.0, 1.1.0, 1.2.0, 1.3.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Minor
> Fix For: 1.4.0
>
> Attachments: Screen Shot 2019-11-18 at 5.13.03 PM.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I browsed the list of {{bugs}} in [https://sonarcloud.io/project/issues?id=knox-gateway&resolved=false&types=BUG] and I believe those issue should be fixed:
> * possible NPE being thrown
> * eliminating "always true" conditions
> * serializing only {{Serializable}} objects
>
> !Screen Shot 2019-11-18 at 5.13.03 PM.png|thumbnail!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)