You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/03 02:38:27 UTC
[GitHub] [skywalking] honganan opened a new pull request #7641: add suffix limit to avoid possible start problems
honganan opened a new pull request #7641:
URL: https://github.com/apache/skywalking/pull/7641
γImprove code robustnessγ
Here reads all files in the directory with Yaml util, in some situation if the directory contains hidden system file such as `.DS_Store` on Mac OS, and I waste many time on it as the error cannot figure out any clues.
<!--
β οΈ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7641: add suffix limit to avoid possible start problems
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7641:
URL: https://github.com/apache/skywalking/pull/7641#issuecomment-912210167
And this doc should be updated, https://skywalking.apache.org/docs/main/latest/en/ui/readme/#custom-dashboard. Because you add new requirements for the file name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7641: add suffix limit to avoid possible start problems
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7641:
URL: https://github.com/apache/skywalking/pull/7641#discussion_r701546287
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java
##########
@@ -376,6 +376,9 @@ public void notifyAfterCompleted() throws ModuleStartException {
try {
final File[] templateFiles = ResourceUtils.getPathFiles("ui-initialized-templates");
for (final File templateFile : templateFiles) {
+ if (!templateFile.getName().endsWith(".yml")) {
Review comment:
Please also take `yaml` into consideration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7641: add suffix limit to avoid possible start problems
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7641:
URL: https://github.com/apache/skywalking/pull/7641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7641: add suffix limit to avoid possible start problems
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7641:
URL: https://github.com/apache/skywalking/pull/7641#issuecomment-912209478
It is fine to add this, please update changes.md in the root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] honganan commented on a change in pull request #7641: add suffix limit to avoid possible start problems
Posted by GitBox <gi...@apache.org>.
honganan commented on a change in pull request #7641:
URL: https://github.com/apache/skywalking/pull/7641#discussion_r701548756
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/CoreModuleProvider.java
##########
@@ -376,6 +376,9 @@ public void notifyAfterCompleted() throws ModuleStartException {
try {
final File[] templateFiles = ResourceUtils.getPathFiles("ui-initialized-templates");
for (final File templateFile : templateFiles) {
+ if (!templateFile.getName().endsWith(".yml")) {
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org