You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/11 01:35:28 UTC
[GitHub] [incubator-seatunnel] yx91490 opened a new pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
yx91490 opened a new pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on a change in pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
yx91490 commented on a change in pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#discussion_r783128142
##########
File path: config/seatunnel-env.sh
##########
@@ -19,4 +19,7 @@
# Home directory of spark distribution.
SPARK_HOME=${SPARK_HOME:-/opt/spark}
# Home directory of flink distribution.
-FLINK_HOME=${FLINK_HOME:-/opt/flink}
\ No newline at end of file
+FLINK_HOME=${FLINK_HOME:-/opt/flink}
+
+# Control the ascii logo string, set to empty to disable it
+export SEATUNNEL_ASCII_LOGO=SeaTunnel
Review comment:
The main purpose is providing a way to hide the logo print, change the logo word is just a fun for some body who want to custom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 removed a comment on pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
yx91490 removed a comment on pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#issuecomment-1009521359
may be blocked by https://github.com/apache/incubator-seatunnel/issues/999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
yx91490 commented on pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#issuecomment-1009521359
may be blocked by https://github.com/apache/incubator-seatunnel/issues/999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#discussion_r781766711
##########
File path: config/seatunnel-env.sh
##########
@@ -19,4 +19,7 @@
# Home directory of spark distribution.
SPARK_HOME=${SPARK_HOME:-/opt/spark}
# Home directory of flink distribution.
-FLINK_HOME=${FLINK_HOME:-/opt/flink}
\ No newline at end of file
+FLINK_HOME=${FLINK_HOME:-/opt/flink}
+
+# Control the ascii logo string, set to empty to disable it
+export SEATUNNEL_ASCII_LOGO=SeaTunnel
Review comment:
hi @yx91490, it seems not necessary let `SEATUNNEL_ASCII_LOGO` as the system env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on a change in pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
yx91490 commented on a change in pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#discussion_r784039091
##########
File path: config/seatunnel-env.sh
##########
@@ -19,4 +19,7 @@
# Home directory of spark distribution.
SPARK_HOME=${SPARK_HOME:-/opt/spark}
# Home directory of flink distribution.
-FLINK_HOME=${FLINK_HOME:-/opt/flink}
\ No newline at end of file
+FLINK_HOME=${FLINK_HOME:-/opt/flink}
+
+# Control the ascii logo string, set to empty to disable it
+export SEATUNNEL_ASCII_LOGO=SeaTunnel
Review comment:
obey your opinion, keep logo string constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] cody1993 commented on a change in pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
cody1993 commented on a change in pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#discussion_r783658116
##########
File path: config/seatunnel-env.sh
##########
@@ -19,4 +19,7 @@
# Home directory of spark distribution.
SPARK_HOME=${SPARK_HOME:-/opt/spark}
# Home directory of flink distribution.
-FLINK_HOME=${FLINK_HOME:-/opt/flink}
\ No newline at end of file
+FLINK_HOME=${FLINK_HOME:-/opt/flink}
+
+# Control the ascii logo string, set to empty to disable it
+export SEATUNNEL_ASCII_LOGO=SeaTunnel
Review comment:
> hi @yx91490, it seems not necessary let `SEATUNNEL_ASCII_LOGO` as the system env.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] garyelephant commented on pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
garyelephant commented on pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#issuecomment-1012763625
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] wuchunfu commented on a change in pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
wuchunfu commented on a change in pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#discussion_r783104572
##########
File path: config/seatunnel-env.sh
##########
@@ -19,4 +19,7 @@
# Home directory of spark distribution.
SPARK_HOME=${SPARK_HOME:-/opt/spark}
# Home directory of flink distribution.
-FLINK_HOME=${FLINK_HOME:-/opt/flink}
\ No newline at end of file
+FLINK_HOME=${FLINK_HOME:-/opt/flink}
+
+# Control the ascii logo string, set to empty to disable it
+export SEATUNNEL_ASCII_LOGO=SeaTunnel
Review comment:
> hi @yx91490, it seems not necessary let `SEATUNNEL_ASCII_LOGO` as the system env.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on a change in pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
yx91490 commented on a change in pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#discussion_r783128142
##########
File path: config/seatunnel-env.sh
##########
@@ -19,4 +19,7 @@
# Home directory of spark distribution.
SPARK_HOME=${SPARK_HOME:-/opt/spark}
# Home directory of flink distribution.
-FLINK_HOME=${FLINK_HOME:-/opt/flink}
\ No newline at end of file
+FLINK_HOME=${FLINK_HOME:-/opt/flink}
+
+# Control the ascii logo string, set to empty to disable it
+export SEATUNNEL_ASCII_LOGO=SeaTunnel
Review comment:
The main purpose is hide the logo print, change the logo word is just a fun for some body who want to custom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#discussion_r782674092
##########
File path: config/seatunnel-env.sh
##########
@@ -19,4 +19,7 @@
# Home directory of spark distribution.
SPARK_HOME=${SPARK_HOME:-/opt/spark}
# Home directory of flink distribution.
-FLINK_HOME=${FLINK_HOME:-/opt/flink}
\ No newline at end of file
+FLINK_HOME=${FLINK_HOME:-/opt/flink}
+
+# Control the ascii logo string, set to empty to disable it
+export SEATUNNEL_ASCII_LOGO=SeaTunnel
Review comment:
We may never change the logo, so it should be a final constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] cody1993 commented on a change in pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
cody1993 commented on a change in pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#discussion_r783658116
##########
File path: config/seatunnel-env.sh
##########
@@ -19,4 +19,7 @@
# Home directory of spark distribution.
SPARK_HOME=${SPARK_HOME:-/opt/spark}
# Home directory of flink distribution.
-FLINK_HOME=${FLINK_HOME:-/opt/flink}
\ No newline at end of file
+FLINK_HOME=${FLINK_HOME:-/opt/flink}
+
+# Control the ascii logo string, set to empty to disable it
+export SEATUNNEL_ASCII_LOGO=SeaTunnel
Review comment:
> hi @yx91490, it seems not necessary let `SEATUNNEL_ASCII_LOGO` as the system env.
+1, logo shouldn't be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie commented on a change in pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#discussion_r783695813
##########
File path: config/seatunnel-env.sh
##########
@@ -19,4 +19,7 @@
# Home directory of spark distribution.
SPARK_HOME=${SPARK_HOME:-/opt/spark}
# Home directory of flink distribution.
-FLINK_HOME=${FLINK_HOME:-/opt/flink}
\ No newline at end of file
+FLINK_HOME=${FLINK_HOME:-/opt/flink}
+
+# Control the ascii logo string, set to empty to disable it
+export SEATUNNEL_ASCII_LOGO=SeaTunnel
Review comment:
I agree with @leo65535 , hard code with the logo is better. But I do not have strong opinions here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] garyelephant merged pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
garyelephant merged pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] yx91490 commented on a change in pull request #1000: [SeaTunnel #998] add an environment variable to control print AsciiLogo
Posted by GitBox <gi...@apache.org>.
yx91490 commented on a change in pull request #1000:
URL: https://github.com/apache/incubator-seatunnel/pull/1000#discussion_r782095342
##########
File path: config/seatunnel-env.sh
##########
@@ -19,4 +19,7 @@
# Home directory of spark distribution.
SPARK_HOME=${SPARK_HOME:-/opt/spark}
# Home directory of flink distribution.
-FLINK_HOME=${FLINK_HOME:-/opt/flink}
\ No newline at end of file
+FLINK_HOME=${FLINK_HOME:-/opt/flink}
+
+# Control the ascii logo string, set to empty to disable it
+export SEATUNNEL_ASCII_LOGO=SeaTunnel
Review comment:
what's your suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org