Re: [PR] [GLUTEN-5682][VL] Fix incorrect result when isNull & isNotNull coexsit in filter [incubator-gluten]

["PHILO-HE (via GitHub)" <gi...@apache.org>]

PHILO-HE commented on code in PR #5670:
URL: https://github.com/apache/incubator-gluten/pull/5670#discussion_r1597319589


##########
cpp/velox/substrait/SubstraitToVeloxPlan.h:
##########
@@ -375,6 +383,9 @@ class SubstraitToVeloxPlanConverter {
 
     bool nullAllowed_ = false;
     bool isNull_ = false;
+    bool forbidsNullSet_ = false;
+    bool isNullSet_ = false;
+    bool existIsNullAndIsNotNull_ = false;

Review Comment:
   Can we just depend on the check for `forbidsNullSet_ && isNullSet_` instead of introducing a new flag? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org