[GitHub] [dubbo-go] LaurenceLiZhixin commented on a diff in pull request #1853: Fix: xds enhancement

[GitBox <gi...@apache.org>]

LaurenceLiZhixin commented on code in PR #1853:
URL: https://github.com/apache/dubbo-go/pull/1853#discussion_r857240508


##########
registry/xds/registry.go:
##########
@@ -60,23 +60,24 @@ func getCategory(url *common.URL) string {
 	return category
 }
 
+// getServiceName return serviceName $(providers_or_consumers):$(interfaceName)
 func getServiceName(url *common.URL) string {
 	var buffer bytes.Buffer
 
 	buffer.Write([]byte(getCategory(url)))
 	appendParam(&buffer, url, constant.InterfaceKey)
-	appendParam(&buffer, url, constant.VersionKey)
-	appendParam(&buffer, url, constant.GroupKey)
 	return buffer.String()
 }
 
+// getSubscribeName returns subscribeName is providers:$(interfaceName)
 func getSubscribeName(url *common.URL) string {
 	var buffer bytes.Buffer
 
 	buffer.Write([]byte(common.DubboNodes[common.PROVIDER]))
 	appendParam(&buffer, url, constant.InterfaceKey)
-	appendParam(&buffer, url, constant.VersionKey)
-	appendParam(&buffer, url, constant.GroupKey)
+	// We would not append group or version to this name, as istio ecosystem only cares about hostname during cds.
+	// The subscribe name is to find real hostName only.
+	// Group or version are managed by traffic policy, not dubbo-go.

Review Comment:
   1. 我改成了during cds procedure.
   2. 修改了
   3. mesh 场景下，Group or version 是由 k8s 流量规则治理的，并非 dubbo-go来关心。
   @AlexStocks 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org