You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Jens Geyer (Jira)" <ji...@apache.org> on 2020/05/17 13:27:00 UTC

[jira] [Commented] (THRIFT-5211) Handle incomplete reads correctly

    [ https://issues.apache.org/jira/browse/THRIFT-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17109478#comment-17109478 ] 

Jens Geyer commented on THRIFT-5211:
------------------------------------

@Phillipp Hausmann: I would have assigned the ticket to you but you do not appear to have an Jira account?

> Handle incomplete reads correctly
> ---------------------------------
>
>                 Key: THRIFT-5211
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5211
>             Project: Thrift
>          Issue Type: Bug
>          Components: Haskell - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Major
>             Fix For: 0.14.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> From [https://github.com/apache/thrift/pull/2108]
> {quote}
> The read functions for handles promise to return _up_ to the requested number of bytes. This means in case we read less bytes, we should try again to read some more bytes. This issue caused invalid frame sizes which caused arbitrary decoding failures.
> I believe that the bug has been introduced in [{{3c42007}}|https://github.com/apache/thrift/commit/3c420072ab5388c2c00d15ada72aec5b061c4d4d]
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)