You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/26 04:38:32 UTC
[GitHub] [thrift] Jimexist commented on a diff in pull request #2678: THRIFT-5641: [build infra] install deps for swift in bionic and focal dockerfile
Jimexist commented on code in PR #2678:
URL: https://github.com/apache/thrift/pull/2678#discussion_r979553965
##########
build/docker/ubuntu-bionic/Dockerfile:
##########
@@ -273,15 +278,11 @@ RUN apt-get install -y --no-install-recommends \
locale-gen de_DE.UTF-8 && \
update-locale
-# cppcheck-1.82 has a nasty cpp parser bug, so we're using something newer
RUN apt-get install -y --no-install-recommends \
`# Static Code Analysis dependencies` \
cppcheck \
sloccount && \
- pip install flake8 && \
- wget -q "https://launchpad.net/ubuntu/+source/cppcheck/1.83-2/+build/14874703/+files/cppcheck_1.83-2_amd64.deb" && \
- dpkg -i cppcheck_1.83-2_amd64.deb && \
- rm cppcheck_1.83-2_amd64.deb
Review Comment:
for bionic the [cppcheck version][1] is now 1.82-1
[1]: https://packages.ubuntu.com/search?keywords=cppcheck
##########
build/docker/ubuntu-focal/Dockerfile:
##########
@@ -258,15 +264,11 @@ RUN apt-get install -y --no-install-recommends \
locale-gen de_DE.UTF-8 && \
update-locale
-# cppcheck-1.82 has a nasty cpp parser bug, so we're using something newer
RUN apt-get install -y --no-install-recommends \
`# Static Code Analysis dependencies` \
cppcheck \
sloccount && \
- pip install flake8 && \
- wget -q "https://launchpad.net/ubuntu/+source/cppcheck/1.83-2/+build/14874703/+files/cppcheck_1.83-2_amd64.deb" && \
- dpkg -i cppcheck_1.83-2_amd64.deb && \
- rm cppcheck_1.83-2_amd64.deb
Review Comment:
for focal the [cppcheck version][1] is now 1.90
[1]: https://packages.ubuntu.com/search?keywords=cppcheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org