You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/10/11 14:07:44 UTC
Review Request 14593: CLOUDSTACK-1833: AUtomation - Adding scale virtual
machine test cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/
-----------------------------------------------------------
Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
Repository: cloudstack-git
Description
-------
Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
More tests to be added on top of this - in progress.
DDT library needed to run the test case.
It can be installed with pip install ddt command.
Diffs
-----
test/integration/component/test_scale_vm.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 0d52224
tools/marvin/marvin/integration/lib/common.py 164ef20
Diff: https://reviews.apache.org/r/14593/diff/
Testing
-------
Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
All test cases running on XenServer, if at all needed, will add log after running them once again.
Thanks,
Gaurav Aradhye
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On Oct. 21, 2013, 3:17 p.m., SrikanteswaraRao Talluri wrote:
> > tools/marvin/setup.py, line 55
> > <https://reviews.apache.org/r/14593/diff/3/?file=365068#file365068line55>
> >
> > Remove brackets
> > "ddt >= 0.4.0" is enough
Done
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/#review27239
-----------------------------------------------------------
On Oct. 21, 2013, 6:24 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14593/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 6:24 p.m.)
>
>
> Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
> More tests to be added on top of this - in progress.
>
> DDT library needed to run the test case.
> It can be installed with pip install ddt command.
>
>
> Diffs
> -----
>
> test/integration/component/test_scale_vm.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 4f15137
> tools/marvin/marvin/integration/lib/common.py 164ef20
> tools/marvin/setup.py eeed3bf
>
> Diff: https://reviews.apache.org/r/14593/diff/
>
>
> Testing
> -------
>
> Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
> All test cases running on XenServer, if at all needed, will add log after running them once again.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/#review27239
-----------------------------------------------------------
tools/marvin/setup.py
<https://reviews.apache.org/r/14593/#comment53055>
Remove brackets
"ddt >= 0.4.0" is enough
- SrikanteswaraRao Talluri
On Oct. 16, 2013, 12:08 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14593/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2013, 12:08 p.m.)
>
>
> Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
> More tests to be added on top of this - in progress.
>
> DDT library needed to run the test case.
> It can be installed with pip install ddt command.
>
>
> Diffs
> -----
>
> test/integration/component/test_scale_vm.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 0d52224
> tools/marvin/marvin/integration/lib/common.py 164ef20
> tools/marvin/setup.py eeed3bf
>
> Diff: https://reviews.apache.org/r/14593/diff/
>
>
> Testing
> -------
>
> Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
> All test cases running on XenServer, if at all needed, will add log after running them once again.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/
-----------------------------------------------------------
(Updated March 17, 2014, 8:39 p.m.)
Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
Repository: cloudstack-git
Description
-------
Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
More tests to be added on top of this - in progress.
DDT library needed to run the test case.
It can be installed with pip install ddt command.
Diffs (updated)
-----
test/integration/component/test_scale_vm.py PRE-CREATION
tools/marvin/marvin/integration/lib/common.py 3b292bf
Diff: https://reviews.apache.org/r/14593/diff/
Testing
-------
Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
All test cases running on XenServer, if at all needed, will add log after running them once again.
Thanks,
Gaurav Aradhye
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/#review27760
-----------------------------------------------------------
test/integration/component/test_scale_vm.py
<https://reviews.apache.org/r/14593/#comment53932>
vmtype is not passed to scale_virtual_machine which is defaulted to 'uservm'
clean all such instances.
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/14593/#comment53931>
vmtype is defaulted to "uservm" and this is not passed even for ssvm. Hence, this will lead to failure in line 806.
- SrikanteswaraRao Talluri
On Oct. 21, 2013, 12:54 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14593/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 12:54 p.m.)
>
>
> Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
> More tests to be added on top of this - in progress.
>
> DDT library needed to run the test case.
> It can be installed with pip install ddt command.
>
>
> Diffs
> -----
>
> test/integration/component/test_scale_vm.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 4f15137
> tools/marvin/marvin/integration/lib/common.py 164ef20
> tools/marvin/setup.py eeed3bf
>
> Diff: https://reviews.apache.org/r/14593/diff/
>
>
> Testing
> -------
>
> Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
> All test cases running on XenServer, if at all needed, will add log after running them once again.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/#review27671
-----------------------------------------------------------
test_19 is failing
- SrikanteswaraRao Talluri
On Oct. 21, 2013, 12:54 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14593/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 12:54 p.m.)
>
>
> Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
> More tests to be added on top of this - in progress.
>
> DDT library needed to run the test case.
> It can be installed with pip install ddt command.
>
>
> Diffs
> -----
>
> test/integration/component/test_scale_vm.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 4f15137
> tools/marvin/marvin/integration/lib/common.py 164ef20
> tools/marvin/setup.py eeed3bf
>
> Diff: https://reviews.apache.org/r/14593/diff/
>
>
> Testing
> -------
>
> Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
> All test cases running on XenServer, if at all needed, will add log after running them once again.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/
-----------------------------------------------------------
(Updated Oct. 21, 2013, 6:24 p.m.)
Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
Changes
-------
Review Changes.
Repository: cloudstack-git
Description
-------
Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
More tests to be added on top of this - in progress.
DDT library needed to run the test case.
It can be installed with pip install ddt command.
Diffs (updated)
-----
test/integration/component/test_scale_vm.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 4f15137
tools/marvin/marvin/integration/lib/common.py 164ef20
tools/marvin/setup.py eeed3bf
Diff: https://reviews.apache.org/r/14593/diff/
Testing
-------
Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
All test cases running on XenServer, if at all needed, will add log after running them once again.
Thanks,
Gaurav Aradhye
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/
-----------------------------------------------------------
(Updated Oct. 16, 2013, 5:38 p.m.)
Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
Changes
-------
Review Changes and added ddt library information in install_requires in setup.py
Repository: cloudstack-git
Description
-------
Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
More tests to be added on top of this - in progress.
DDT library needed to run the test case.
It can be installed with pip install ddt command.
Diffs (updated)
-----
test/integration/component/test_scale_vm.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 0d52224
tools/marvin/marvin/integration/lib/common.py 164ef20
tools/marvin/setup.py eeed3bf
Diff: https://reviews.apache.org/r/14593/diff/
Testing
-------
Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
All test cases running on XenServer, if at all needed, will add log after running them once again.
Thanks,
Gaurav Aradhye
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/#review27060
-----------------------------------------------------------
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/14593/#comment52686>
remove print statement
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/14593/#comment52687>
remove print statement
- SrikanteswaraRao Talluri
On Oct. 16, 2013, 7:54 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14593/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2013, 7:54 a.m.)
>
>
> Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
> More tests to be added on top of this - in progress.
>
> DDT library needed to run the test case.
> It can be installed with pip install ddt command.
>
>
> Diffs
> -----
>
> test/integration/component/test_scale_vm.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 0d52224
> tools/marvin/marvin/integration/lib/common.py 164ef20
>
> Diff: https://reviews.apache.org/r/14593/diff/
>
>
> Testing
> -------
>
> Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
> All test cases running on XenServer, if at all needed, will add log after running them once again.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On Oct. 16, 2013, 2:59 p.m., SrikanteswaraRao Talluri wrote:
> > test/integration/component/test_scale_vm.py, line 98
> > <https://reviews.apache.org/r/14593/diff/2/?file=365062#file365062line98>
> >
> > this is redundant, it is always better to get the mode populated when the test is actually run.
> > you are already doing it with the following statement
> > cls.services["mode"] = cls.zone.networktype
Removed this statement. Passed networkType in mode parameter directly while creating Virtual machine. It wasn't used anywhere else so not required to reassign the value.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/#review27061
-----------------------------------------------------------
On Oct. 16, 2013, 5:38 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14593/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2013, 5:38 p.m.)
>
>
> Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
> More tests to be added on top of this - in progress.
>
> DDT library needed to run the test case.
> It can be installed with pip install ddt command.
>
>
> Diffs
> -----
>
> test/integration/component/test_scale_vm.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 0d52224
> tools/marvin/marvin/integration/lib/common.py 164ef20
> tools/marvin/setup.py eeed3bf
>
> Diff: https://reviews.apache.org/r/14593/diff/
>
>
> Testing
> -------
>
> Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
> All test cases running on XenServer, if at all needed, will add log after running them once again.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/#review27061
-----------------------------------------------------------
test/integration/component/test_scale_vm.py
<https://reviews.apache.org/r/14593/#comment52688>
this is redundant, it is always better to get the mode populated when the test is actually run.
you are already doing it with the following statement
cls.services["mode"] = cls.zone.networktype
- SrikanteswaraRao Talluri
On Oct. 16, 2013, 7:54 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14593/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2013, 7:54 a.m.)
>
>
> Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
> More tests to be added on top of this - in progress.
>
> DDT library needed to run the test case.
> It can be installed with pip install ddt command.
>
>
> Diffs
> -----
>
> test/integration/component/test_scale_vm.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 0d52224
> tools/marvin/marvin/integration/lib/common.py 164ef20
>
> Diff: https://reviews.apache.org/r/14593/diff/
>
>
> Testing
> -------
>
> Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
> All test cases running on XenServer, if at all needed, will add log after running them once again.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding
scale virtual machine test cases
Posted by Srikanteswararao Talluri <sr...@citrix.com>.
+1
~Talluri
On 16/10/13 2:29 PM, "Santhosh Edukulla" <sa...@citrix.com>
wrote:
>If ddt library is required for running tests, please add this dependency
>to marvin setup.py "install_requires" list with relevant version
>requirement information. This will be easier to get the required
>packages.
>
>Santhosh
>________________________________________
>From: Gaurav Aradhye [noreply@reviews.apache.org] on behalf of Gaurav
>Aradhye [gaurav.aradhye@clogeny.com]
>Sent: Wednesday, October 16, 2013 3:54 AM
>To: Srikanteswararao Talluri; Nitin Mehta
>Cc: Gaurav Aradhye; cloudstack
>Subject: Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding
>scale virtual machine test cases
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/14593/
>-----------------------------------------------------------
>
>(Updated Oct. 16, 2013, 1:24 p.m.)
>
>
>Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
>
>
>Changes
>-------
>
>Removing Skips
>
>
>Summary (updated)
>-----------------
>
>CLOUDSTACK-1833: Automation - Adding scale virtual machine test cases
>
>
>Repository: cloudstack-git
>
>
>Description
>-------
>
>Some of the basic P1 test cases for scaling up CPU and RAM for running
>VMs.
>More tests to be added on top of this - in progress.
>
>DDT library needed to run the test case.
>It can be installed with pip install ddt command.
>
>
>Diffs (updated)
>-----
>
> test/integration/component/test_scale_vm.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 0d52224
> tools/marvin/marvin/integration/lib/common.py 164ef20
>
>Diff: https://reviews.apache.org/r/14593/diff/
>
>
>Testing
>-------
>
>Tested on XenServer. Not attaching logs because different test cases were
>run at different time, not all at once.
>All test cases running on XenServer, if at all needed, will add log after
>running them once again.
>
>
>Thanks,
>
>Gaurav Aradhye
RE: Review Request 14593: CLOUDSTACK-1833: Automation - Adding
scale virtual machine test cases
Posted by Santhosh Edukulla <sa...@citrix.com>.
If ddt library is required for running tests, please add this dependency to marvin setup.py "install_requires" list with relevant version requirement information. This will be easier to get the required packages.
Santhosh
________________________________________
From: Gaurav Aradhye [noreply@reviews.apache.org] on behalf of Gaurav Aradhye [gaurav.aradhye@clogeny.com]
Sent: Wednesday, October 16, 2013 3:54 AM
To: Srikanteswararao Talluri; Nitin Mehta
Cc: Gaurav Aradhye; cloudstack
Subject: Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual machine test cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/
-----------------------------------------------------------
(Updated Oct. 16, 2013, 1:24 p.m.)
Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
Changes
-------
Removing Skips
Summary (updated)
-----------------
CLOUDSTACK-1833: Automation - Adding scale virtual machine test cases
Repository: cloudstack-git
Description
-------
Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
More tests to be added on top of this - in progress.
DDT library needed to run the test case.
It can be installed with pip install ddt command.
Diffs (updated)
-----
test/integration/component/test_scale_vm.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 0d52224
tools/marvin/marvin/integration/lib/common.py 164ef20
Diff: https://reviews.apache.org/r/14593/diff/
Testing
-------
Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
All test cases running on XenServer, if at all needed, will add log after running them once again.
Thanks,
Gaurav Aradhye
Re: Review Request 14593: CLOUDSTACK-1833: Automation - Adding scale virtual
machine test cases
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14593/
-----------------------------------------------------------
(Updated Oct. 16, 2013, 1:24 p.m.)
Review request for cloudstack, Nitin Mehta and SrikanteswaraRao Talluri.
Changes
-------
Removing Skips
Summary (updated)
-----------------
CLOUDSTACK-1833: Automation - Adding scale virtual machine test cases
Repository: cloudstack-git
Description
-------
Some of the basic P1 test cases for scaling up CPU and RAM for running VMs.
More tests to be added on top of this - in progress.
DDT library needed to run the test case.
It can be installed with pip install ddt command.
Diffs (updated)
-----
test/integration/component/test_scale_vm.py PRE-CREATION
tools/marvin/marvin/integration/lib/base.py 0d52224
tools/marvin/marvin/integration/lib/common.py 164ef20
Diff: https://reviews.apache.org/r/14593/diff/
Testing
-------
Tested on XenServer. Not attaching logs because different test cases were run at different time, not all at once.
All test cases running on XenServer, if at all needed, will add log after running them once again.
Thanks,
Gaurav Aradhye