You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by bourneagain <gi...@git.apache.org> on 2015/06/12 20:18:12 UTC
[GitHub] storm pull request: STORM-67 Provide API for spouts to know how ma...
GitHub user bourneagain opened a pull request:
https://github.com/apache/storm/pull/593
STORM-67 Provide API for spouts to know how many pending messages there are
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bourneagain/storm STORM-67
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/593.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #593
----
commit e035ab6f9d20c1ea632c5e999dcf10fc0ce1e2e5
Author: Shyam Rajendran <sr...@yahoo-inc.com>
Date: 2015-06-11T17:38:49Z
STORM-67 Provide API for spouts to know how many pending messages there
are
- changes to classes implementing ISpoutOutputCollector
- executor.clj getPendingCount definition
commit 4e832436134ada6639f7520c0445ea05e8130f6c
Author: Shyam Rajendran <sr...@yahoo-inc.com>
Date: 2015-06-12T18:04:22Z
Merge branch 'master' into STORM-67
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-67 Provide API for spouts to know how ma...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/593#discussion_r33310534
--- Diff: storm-core/src/jvm/storm/trident/spout/RichSpoutBatchTriggerer.java ---
@@ -27,17 +27,12 @@
import backtype.storm.tuple.Fields;
import backtype.storm.tuple.Values;
import backtype.storm.utils.Utils;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Random;
-import java.util.Set;
import storm.trident.topology.TridentBoltExecutor;
import storm.trident.tuple.ConsList;
import storm.trident.util.TridentUtils;
+import java.util.*;
--- End diff --
Let's not import java.util.*.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-67 Provide API for spouts to know how ma...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/593
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-67 Provide API for spouts to know how ma...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/593#issuecomment-120600320
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-67 Provide API for spouts to know how ma...
Posted by bourneagain <gi...@git.apache.org>.
Github user bourneagain commented on the pull request:
https://github.com/apache/storm/pull/593#issuecomment-118856776
I am working on few more review comments presently and shall update as soon as its available for further review. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-67 Provide API for spouts to know how ma...
Posted by bourneagain <gi...@git.apache.org>.
Github user bourneagain commented on the pull request:
https://github.com/apache/storm/pull/593#issuecomment-121281726
Thanks @HeartSaVioR .We can have this merged to master whenever we feel appropriate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---