You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by benbenw <gi...@git.apache.org> on 2016/01/31 12:20:17 UTC
[GitHub] jmeter pull request: misc clean of ldap code
GitHub user benbenw opened a pull request:
https://github.com/apache/jmeter/pull/96
misc clean of ldap code
commented code, empty java doc, variables naming, etc...
Does anybody use this code ?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benbenw/jmeter ldapclean
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
commit 42c78514c9451988588e167c5e7800633f775075
Author: benoit <b....@ubik-ingenierie.com>
Date: 2016-01-31T11:19:17Z
misc clean of ldap code
commented code, empty java doc, variables naming, etc...
Does anybody use this code ?
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: misc clean of ldap code
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] jmeter pull request: misc clean of ldap code
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 31.01.2016 um 13:36 schrieb benbenw:
> Github user benbenw commented on the pull request:
>
> https://github.com/apache/jmeter/pull/96#issuecomment-177489147
>
> user_defined is in a gui (LdapConfigGui)
> when is the gui serialized ?
The gui is serialized into the jmx files, but not directly, so you are
right and it should have no impact in our case.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] jmeter pull request: misc clean of ldap code
Posted by benbenw <gi...@git.apache.org>.
Github user benbenw commented on the pull request:
https://github.com/apache/jmeter/pull/96#issuecomment-177489147
user_defined is in a gui (LdapConfigGui)
when is the gui serialized ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: misc clean of ldap code
Posted by FSchumacher <gi...@git.apache.org>.
Github user FSchumacher commented on the pull request:
https://github.com/apache/jmeter/pull/96#issuecomment-177472243
I think the patch does too much in one. The javadoc formatting is debatable. My eclipse format would re-format it to the orig form. I will try to look at your changes and commit those, that I think are valid without discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---