You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Paul Cantrell (JIRA)" <ta...@jakarta.apache.org> on 2006/05/08 01:19:21 UTC
[jira] Created: (TAPESTRY-937) Custom binding prefixes shorter than
2 characters fail without useful diagnostics
Custom binding prefixes shorter than 2 characters fail without useful diagnostics
---------------------------------------------------------------------------------
Key: TAPESTRY-937
URL: http://issues.apache.org/jira/browse/TAPESTRY-937
Project: Tapestry
Type: Bug
Components: Framework
Versions: 4.0.1
Environment: Java 1.5, OS X 10.4.6
Reporter: Paul Cantrell
It should be possible to specify custom binding prefixes consisting of one character, or even of the empty string, e.g.:
<contribution configuration-id="tapestry.bindings.BindingFactories">
<binding prefix="" service-id="tapestry.bindings.OGNLBindingFactory"/>
<binding prefix="C" service-id="tapestry.bindings.ComponentBindingFactory"/>
</contribution>
This configuration should cause "C:foo" to be equivalent to "component:foo", and ":bar" to be equivalent to "component:bar". However, Tapestry silently ignores prefixes shorter than two characters, treating "C:foo" as a literal even with the above configuration.
Tapestry should do one of two things:
(1) Hopefully this behavior is unintentional. If so, it is due to a dropped minus sign on line 63 of BindingSourceImpl:
if (colonx > 1)
...should be:
if (colonx > -1)
(2) If this behavior is intentional, BindingSourceImpl should reject any invalid contributions up front instead of ignoring them.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-937) Custom binding prefixes shorter
than 2 characters fail without useful diagnostics
Posted by "Paul Cantrell (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-937?page=comments#action_12378343 ]
Paul Cantrell commented on TAPESTRY-937:
----------------------------------------
A typo in the above, in paragraph 2:
":bar" should be equivalent to "component:bar"
...should read:
":bar" should be equivalent to "ognl:bar"
> Custom binding prefixes shorter than 2 characters fail without useful diagnostics
> ---------------------------------------------------------------------------------
>
> Key: TAPESTRY-937
> URL: http://issues.apache.org/jira/browse/TAPESTRY-937
> Project: Tapestry
> Type: Bug
> Components: Framework
> Versions: 4.0.1
> Environment: Java 1.5, OS X 10.4.6
> Reporter: Paul Cantrell
>
> It should be possible to specify custom binding prefixes consisting of one character, or even of the empty string, e.g.:
> <contribution configuration-id="tapestry.bindings.BindingFactories">
> <binding prefix="" service-id="tapestry.bindings.OGNLBindingFactory"/>
> <binding prefix="C" service-id="tapestry.bindings.ComponentBindingFactory"/>
> </contribution>
> This configuration should cause "C:foo" to be equivalent to "component:foo", and ":bar" to be equivalent to "component:bar". However, Tapestry silently ignores prefixes shorter than two characters, treating "C:foo" as a literal even with the above configuration.
> Tapestry should do one of two things:
> (1) Hopefully this behavior is unintentional. If so, it is due to a dropped minus sign on line 63 of BindingSourceImpl:
> if (colonx > 1)
>
> ...should be:
> if (colonx > -1)
> (2) If this behavior is intentional, BindingSourceImpl should reject any invalid contributions up front instead of ignoring them.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-937) Custom binding prefixes shorter than
2 characters fail without useful diagnostics
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-937?page=all ]
Jesse Kuhnert updated TAPESTRY-937:
-----------------------------------
Fix Version/s: 4.1.2
> Custom binding prefixes shorter than 2 characters fail without useful diagnostics
> ---------------------------------------------------------------------------------
>
> Key: TAPESTRY-937
> URL: http://issues.apache.org/jira/browse/TAPESTRY-937
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.0.1
> Environment: Java 1.5, OS X 10.4.6
> Reporter: Paul Cantrell
> Fix For: 4.1.2
>
>
> It should be possible to specify custom binding prefixes consisting of one character, or even of the empty string, e.g.:
> <contribution configuration-id="tapestry.bindings.BindingFactories">
> <binding prefix="" service-id="tapestry.bindings.OGNLBindingFactory"/>
> <binding prefix="C" service-id="tapestry.bindings.ComponentBindingFactory"/>
> </contribution>
> This configuration should cause "C:foo" to be equivalent to "component:foo", and ":bar" to be equivalent to "component:bar". However, Tapestry silently ignores prefixes shorter than two characters, treating "C:foo" as a literal even with the above configuration.
> Tapestry should do one of two things:
> (1) Hopefully this behavior is unintentional. If so, it is due to a dropped minus sign on line 63 of BindingSourceImpl:
> if (colonx > 1)
>
> ...should be:
> if (colonx > -1)
> (2) If this behavior is intentional, BindingSourceImpl should reject any invalid contributions up front instead of ignoring them.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-937) Custom binding prefixes shorter
than 2 characters fail without useful diagnostics
Posted by "Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Kuhnert resolved TAPESTRY-937.
------------------------------------
Resolution: Fixed
Assignee: Jesse Kuhnert
Accepts empty/2 character / etc.Sorry it took so long.
> Custom binding prefixes shorter than 2 characters fail without useful diagnostics
> ---------------------------------------------------------------------------------
>
> Key: TAPESTRY-937
> URL: https://issues.apache.org/jira/browse/TAPESTRY-937
> Project: Tapestry
> Issue Type: Bug
> Components: Framework
> Affects Versions: 4.0.1
> Environment: Java 1.5, OS X 10.4.6
> Reporter: Paul Cantrell
> Assigned To: Jesse Kuhnert
> Fix For: 4.1.2
>
>
> It should be possible to specify custom binding prefixes consisting of one character, or even of the empty string, e.g.:
> <contribution configuration-id="tapestry.bindings.BindingFactories">
> <binding prefix="" service-id="tapestry.bindings.OGNLBindingFactory"/>
> <binding prefix="C" service-id="tapestry.bindings.ComponentBindingFactory"/>
> </contribution>
> This configuration should cause "C:foo" to be equivalent to "component:foo", and ":bar" to be equivalent to "component:bar". However, Tapestry silently ignores prefixes shorter than two characters, treating "C:foo" as a literal even with the above configuration.
> Tapestry should do one of two things:
> (1) Hopefully this behavior is unintentional. If so, it is due to a dropped minus sign on line 63 of BindingSourceImpl:
> if (colonx > 1)
>
> ...should be:
> if (colonx > -1)
> (2) If this behavior is intentional, BindingSourceImpl should reject any invalid contributions up front instead of ignoring them.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org