[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost by payload

[GitBox <gi...@apache.org>]

alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost by payload 
URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-583474019
 
 
   hi @romseygeek , @dsmiley ,
   first of all, thank you again for your patience and very useful insights.
   I have incorporated Alan's changes and cleaned everything up.
   
   My un-resolved questions:
   - boostAttribute doesn’t use BytesRef but directly float, is it a concern? We are expected to use it at query time, so we could actually see a query time minimal benefit in not encoding/decoding?
   - Alan expressed concerns over SpanBoostQuery, mentioning they are sort of broken, what should we do in that regard? right now the create span query seems to work as expected with boosted synonyms(see the related test), I suspect if SpanBoostQuery are broken , they should get resolved in another ticket?
   - from an original comment in the test code org.apache.solr.search.TestSolrQueryParser#testSynonymQueryStyle:
   "confirm autoGeneratePhraseQueries always builds OR queries"
   I changed that, was there any reason for that behaviour?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org