You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/05/06 19:02:57 UTC

[GitHub] [celix] abroekhuis commented on a change in pull request #202: Updated gtest setup to either use GTest supplied Config file, or (if …

abroekhuis commented on a change in pull request #202:
URL: https://github.com/apache/celix/pull/202#discussion_r421023821



##########
File path: CMakeLists.txt
##########
@@ -41,7 +41,7 @@ ELSE ()
     set(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu99 -fPIC ${CMAKE_C_FLAGS}")
     set(CMAKE_CXX_FLAGS "-std=c++11 -fno-rtti ${CMAKE_CXX_FLAGS}")
     set(CMAKE_C_FLAGS "-Wall -Werror ${CMAKE_C_FLAGS}")
-    set(CMAKE_CXX_FLAGS "-Wall -Wextra -Weffc++ ${CMAKE_CXX_FLAGS}")

Review comment:
       I've moved the inclusion of gtest to before the flags. This works. Since it is an external dependency, I think we can do without the flags. But.. if needed we can split up the flags (or even move Werror) so that the build does not fail due to gtest source.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org