You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/13 06:57:10 UTC

[GitHub] [iotdb] yanhongwangg opened a new pull request #2999: Increase the limited log file size

yanhongwangg opened a new pull request #2999:
URL: https://github.com/apache/iotdb/pull/2999


   Follow the previous configuration，Too many files will be generated。
   ![image](https://user-images.githubusercontent.com/67779101/114509717-6e89f980-9c68-11eb-855d-fcfe1226e83d.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] wangchao316 commented on a change in pull request #2999: Increase the limited log file size

Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #2999:
URL: https://github.com/apache/iotdb/pull/2999#discussion_r617249661



##########
File path: server/src/assembly/resources/conf/logback.xml
##########
@@ -46,7 +46,7 @@
         <file>${IOTDB_HOME}/logs/log_warn.log</file>
         <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
             <fileNamePattern>${IOTDB_HOME}/logs/log-warn-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
-            <maxFileSize>10MB</maxFileSize>
+            <maxFileSize>200MB</maxFileSize>

Review comment:
       hi @neuyilan 
   The log printing level and log printing frequency are distinguished.
   Generally, the value of info is 35 MB.
   Generally, the value of warn is 50 MB.
   Generally, the debug value is 125 MB.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan commented on a change in pull request #2999: Increase the limited log file size

Posted by GitBox <gi...@apache.org>.
neuyilan commented on a change in pull request #2999:
URL: https://github.com/apache/iotdb/pull/2999#discussion_r617254703



##########
File path: server/src/assembly/resources/conf/logback.xml
##########
@@ -46,7 +46,7 @@
         <file>${IOTDB_HOME}/logs/log_warn.log</file>
         <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
             <fileNamePattern>${IOTDB_HOME}/logs/log-warn-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
-            <maxFileSize>10MB</maxFileSize>
+            <maxFileSize>200MB</maxFileSize>

Review comment:
       Hi, @wangchao316 Thanks a lot.
   Hi @yanhongwangg, maybe you could revise your codes according to @wangchao316's suggestions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] wangchao316 commented on a change in pull request #2999: Increase the limited log file size

Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #2999:
URL: https://github.com/apache/iotdb/pull/2999#discussion_r612249090



##########
File path: server/src/assembly/resources/conf/logback.xml
##########
@@ -46,7 +46,7 @@
         <file>${IOTDB_HOME}/logs/log_warn.log</file>
         <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
             <fileNamePattern>${IOTDB_HOME}/logs/log-warn-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
-            <maxFileSize>10MB</maxFileSize>
+            <maxFileSize>200MB</maxFileSize>

Review comment:
       If the value of maxfilesize is large and logs are queried and written during log compression, performance jitters may occur. This has been a problem in our production environment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #2999: Increase the limited log file size

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2999:
URL: https://github.com/apache/iotdb/pull/2999#discussion_r612215988



##########
File path: server/src/assembly/resources/conf/logback.xml
##########
@@ -65,7 +65,7 @@
         <file>${IOTDB_HOME}/logs/log_info.log</file>
         <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
             <fileNamePattern>${IOTDB_HOME}/logs/log-info-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
-            <maxFileSize>50MB</maxFileSize>
+            <maxFileSize>1GB</maxFileSize>

Review comment:
       Is 1GB too large?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] yanhongwangg closed pull request #2999: Increase the limited log file size

Posted by GitBox <gi...@apache.org>.
yanhongwangg closed pull request #2999:
URL: https://github.com/apache/iotdb/pull/2999


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan commented on a change in pull request #2999: Increase the limited log file size

Posted by GitBox <gi...@apache.org>.
neuyilan commented on a change in pull request #2999:
URL: https://github.com/apache/iotdb/pull/2999#discussion_r617239175



##########
File path: server/src/assembly/resources/conf/logback.xml
##########
@@ -46,7 +46,7 @@
         <file>${IOTDB_HOME}/logs/log_warn.log</file>
         <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
             <fileNamePattern>${IOTDB_HOME}/logs/log-warn-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
-            <maxFileSize>10MB</maxFileSize>
+            <maxFileSize>200MB</maxFileSize>

Review comment:
       Hi, @wangchao316 do you have any suggestions according to your experience?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] yanhongwangg commented on a change in pull request #2999: Increase the limited log file size

Posted by GitBox <gi...@apache.org>.
yanhongwangg commented on a change in pull request #2999:
URL: https://github.com/apache/iotdb/pull/2999#discussion_r612255961



##########
File path: server/src/assembly/resources/conf/logback.xml
##########
@@ -65,7 +65,7 @@
         <file>${IOTDB_HOME}/logs/log_info.log</file>
         <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
             <fileNamePattern>${IOTDB_HOME}/logs/log-info-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
-            <maxFileSize>50MB</maxFileSize>
+            <maxFileSize>1GB</maxFileSize>

Review comment:
       emmm,maybe




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] yanhongwangg commented on a change in pull request #2999: Increase the limited log file size

Posted by GitBox <gi...@apache.org>.
yanhongwangg commented on a change in pull request #2999:
URL: https://github.com/apache/iotdb/pull/2999#discussion_r612255638



##########
File path: server/src/assembly/resources/conf/logback.xml
##########
@@ -46,7 +46,7 @@
         <file>${IOTDB_HOME}/logs/log_warn.log</file>
         <rollingPolicy class="ch.qos.logback.core.rolling.SizeAndTimeBasedRollingPolicy">
             <fileNamePattern>${IOTDB_HOME}/logs/log-warn-%d{yyyyMMdd-HH}.%i.log.gz</fileNamePattern>
-            <maxFileSize>10MB</maxFileSize>
+            <maxFileSize>200MB</maxFileSize>

Review comment:
       emmm,What size do you think is appropriate




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org