[GitHub] sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.

[GitBox <gi...@apache.org>]

sohami commented on a change in pull request #1344: DRILL-6461: Added basic data correctness tests for hash agg, and improved operator unit testing framework.
URL: https://github.com/apache/drill/pull/1344#discussion_r207977722
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java
 ##########
 @@ -42,6 +42,8 @@
   private final BufferAllocator allocator;
   protected final List<VectorWrapper<?>> wrappers = Lists.newArrayList();
   private BatchSchema schema;
+  private SelectionVector2 selectionVector2;
+  private SelectionVector4 selectionVector4;
 
 Review comment:
   I don't think we should include SV2/SV4 inside a VectorContainer. They are more of RecordBatch level members. VectorContainer should only have metadata and set of vectors in it which is what it is today.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services