[jira] Commented: (SCM-508) Wrong scm url validation for mercurial provider

["Andreas Ebbert-Karroum (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/SCM-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=221777#action_221777 ] 

Andreas Ebbert-Karroum commented on SCM-508:
--------------------------------------------

The webpage for the hg scm provider shows example URLs

http://maven.apache.org/scm/mercurial.html

{quote}
scm:hg:http://host/v3
scm:hg:file://C:/dev/project/v3 (windows drive)
scm:hg:file:///home/smorgrav/dev/project/v3 (linux drive)
scm:hg:/home/smorgrav/dev/project/v3 (local directory)
{quote}

So on Windows its two slashes, on linux its three. It'd be nice if the plugin worked on linux AND windows.

> Wrong scm url validation for mercurial provider
> -----------------------------------------------
>
>                 Key: SCM-508
>                 URL: http://jira.codehaus.org/browse/SCM-508
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-mercurial (hg)
>            Reporter: Alexander Nemish
>
> According to documentation (http://maven.apache.org/scm/mercurial.html) scm url can be of this form:
> scm:hg:file://C:/dev/project/v3
> but it doesn't work due to a bug in https://svn.apache.org/repos/asf/maven/scm/tags/maven-scm-1.2/maven-scm-providers/maven-scm-provider-hg/src/main/java/org/apache/maven/scm/provider/hg/HgScmProvider.java
> private HgUrlParserResult parseScmUrl( String scmSpecificUrl )
> line 104: if ( !url.startsWith( "file:///" ) && !url.startsWith( "file://localhost/" ) )
> The fix might be the following (like in svn provider)
> line 104: if ( !url.startsWith( "file://" ) && !url.startsWith( "file://localhost/" ) )

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira