You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/14 06:28:15 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #8561: [fix] csv upload param formatting in create engine

codecov-io commented on issue #8561: [fix] csv upload param formatting in create engine
URL: https://github.com/apache/incubator-superset/pull/8561#issuecomment-553745394
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8561?src=pr&el=h1) Report
   > Merging [#8561](https://codecov.io/gh/apache/incubator-superset/pull/8561?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/59bc220602a1e74f3df19902978512f276ee2d88?src=pr&el=desc) will **increase** coverage by `0.05%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8561/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8561?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8561      +/-   ##
   ==========================================
   + Coverage   66.75%   66.81%   +0.05%     
   ==========================================
     Files         450      450              
     Lines       22734    22742       +8     
     Branches     2366     2366              
   ==========================================
   + Hits        15177    15195      +18     
   + Misses       7419     7409      -10     
     Partials      138      138
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8561?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8561/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.84% <100%> (+0.51%)` | :arrow_up: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8561/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `83.33% <0%> (+27.77%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8561?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8561?src=pr&el=footer). Last update [59bc220...412523f](https://codecov.io/gh/apache/incubator-superset/pull/8561?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org