You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/19 21:50:21 UTC
[GitHub] [superset] etr2460 opened a new pull request #15786: fix: Bust chart cache when metric/column is changed
etr2460 opened a new pull request #15786:
URL: https://github.com/apache/superset/pull/15786
### SUMMARY
Back in https://github.com/apache/superset/pull/8901 @villebro made changes to include `datasource.changed_on` to the chart cache key so that a change to the datasource would bust the chart cache. This was important because a user could change the sql for a datasource, but rerunning the chart wouldn't rerun the query before.
In this PR it seems like we intended to also bust the cache when metrics/columns were changed (https://github.com/apache/superset/pull/8901/files#r372541748) but that doesn't seem to work. This PR addresses that oversight and adds a test to check it
### TESTING INSTRUCTIONS
CI, new unit test
create a chart, update a metric, see the chart's cache busted
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @john-bodley @villebro @dpgaspar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15786: fix: Bust chart cache when metric/column is changed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15786:
URL: https://github.com/apache/superset/pull/15786#issuecomment-884249013
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #15786: fix: Bust chart cache when metric/column is changed
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #15786:
URL: https://github.com/apache/superset/pull/15786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #15786: fix: Bust chart cache when metric/column is changed
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #15786:
URL: https://github.com/apache/superset/pull/15786#issuecomment-883470560
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15786: fix: Bust chart cache when metric/column is changed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15786:
URL: https://github.com/apache/superset/pull/15786#issuecomment-883472796
@etr2460 Ephemeral environment spinning up at http://54.184.252.217:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org