[GitHub] jerrypeng commented on issue #2259: Fix: set subscription-type based on message ordering

[GitBox <gi...@apache.org>]

jerrypeng commented on issue #2259: Fix: set subscription-type based on message ordering
URL: https://github.com/apache/incubator-pulsar/pull/2259#issuecomment-409335711
 
 
   @rdhabalia @merlimat @sijie @srkukarni 
   I don't believe we have to correct mechanism for setting the subscription type in this PR as well as in CmdSinks base off of the retainOrder flag.  
   
   For functions, sources, and sinks, if the processing guarantee is set to effectively once, it is implied that order should be maintained and the subscription type to be failover.  Only for at-most-once and at-once processing guarantees should we allow the user the change/choose between failover and shared.  I think we should bring back the subscriptionType flag for users to be able to override the subscription type when in at-most-once or at-least-once mode.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services