[GitHub] [hive] laszlopinter86 commented on a change in pull request #1243: HIVE-23832: Compaction cleaner fails to clean up deltas when using bl…

[GitBox <gi...@apache.org>]

laszlopinter86 commented on a change in pull request #1243:
URL: https://github.com/apache/hive/pull/1243#discussion_r453682925



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/compact/AlterTableCompactOperation.java
##########
@@ -99,7 +99,7 @@ private void waitForCompactionToFinish(CompactionResponse resp) throws HiveExcep
     wait: while (true) {
       //double wait time until 5min
       waitTimeMs = waitTimeMs*2;
-      waitTimeMs = Math.max(waitTimeMs, waitTimeOut);
+      waitTimeMs = Math.min(waitTimeMs, waitTimeOut);

Review comment:
       Why do we need this change? Per the documentation, the minimum wait timeout is 2000 ms




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org