[GitHub] [arrow-rs] xrl commented on a change in pull request #539: generate parquet schema from rust struct

[GitBox <gi...@apache.org>]

xrl commented on a change in pull request #539:
URL: https://github.com/apache/arrow-rs/pull/539#discussion_r668239192



##########
File path: parquet_derive/src/lib.rs
##########
@@ -69,7 +64,7 @@ mod parquet_field;
 ///     }
 ///   ];
 ///
-///  let schema = Arc::new(parse_message_type(schema_str).unwrap());
+///  let schema = samples.as_slice().schema();

Review comment:
       I appreciate the extra attention to this code. My team relies on the derive macro to translate simple structs to parquet, which we do very often in our data pipeline. I'd be happy to test out future, more comprehensive versions. I applaud you effort, I was too intimidated by the record writer to keep going!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org