You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "baldimir (via GitHub)" <gi...@apache.org> on 2023/10/12 13:46:42 UTC
[PR] [kie-issues#628] Change JBoss Nexus to Apache Nexus. [incubator-kie-optaplanner]
baldimir opened a new pull request, #3001:
URL: https://github.com/apache/incubator-kie-optaplanner/pull/3001
Changes JBoss Nexus repository to Apache Nexus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#628] Change JBoss Nexus to Apache Nexus. [incubator-kie-optaplanner]
Posted by "jstastny-cz (via GitHub)" <gi...@apache.org>.
jstastny-cz commented on code in PR #3001:
URL: https://github.com/apache/incubator-kie-optaplanner/pull/3001#discussion_r1357989592
##########
build/optaplanner-build-parent/pom.xml:
##########
@@ -474,7 +474,6 @@
<author>false</author>
<failOnError>true</failOnError>
<failOnWarnings>true</failOnWarnings>
- <!-- Override JBoss parent otherwise it fails on JDK 16+ -->
Review Comment:
Wouldn't this override be worth trying to remove? We can track as follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#628] Change JBoss Nexus to Apache Nexus. [incubator-kie-optaplanner]
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on code in PR #3001:
URL: https://github.com/apache/incubator-kie-optaplanner/pull/3001#discussion_r1358106909
##########
build/optaplanner-build-parent/pom.xml:
##########
@@ -474,7 +474,6 @@
<author>false</author>
<failOnError>true</failOnError>
<failOnWarnings>true</failOnWarnings>
- <!-- Override JBoss parent otherwise it fails on JDK 16+ -->
Review Comment:
Fixed. I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [kie-issues#628] Change JBoss Nexus to Apache Nexus. [incubator-kie-optaplanner]
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir merged PR #3001:
URL: https://github.com/apache/incubator-kie-optaplanner/pull/3001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org