You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2024/08/05 11:24:00 UTC
[PR] feat: create dag_schedule_dataset_alias_reference [airflow]
Lee-W opened a new pull request, #41264:
URL: https://github.com/apache/airflow/pull/41264
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add DatasetDagRunQueue to all the consuming DAGs of a dataset alias [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #41264:
URL: https://github.com/apache/airflow/pull/41264#discussion_r1705340564
##########
airflow/datasets/__init__.py:
##########
@@ -294,6 +297,9 @@ def as_expression(self) -> Any:
def iter_datasets(self) -> Iterator[tuple[str, Dataset]]:
yield self.uri, self
+ def iter_dataset_aliases(self) -> Iterator[DatasetAlias]:
+ raise StopIteration()
Review Comment:
Alternatively I think this would work
```python
def iter_....:
return
yield # Hack to make Python turn this into a generator function.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add DatasetDagRunQueue to all the consuming DAGs of a dataset alias [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #41264:
URL: https://github.com/apache/airflow/pull/41264#discussion_r1705338968
##########
airflow/datasets/__init__.py:
##########
@@ -294,6 +297,9 @@ def as_expression(self) -> Any:
def iter_datasets(self) -> Iterator[tuple[str, Dataset]]:
yield self.uri, self
+ def iter_dataset_aliases(self) -> Iterator[DatasetAlias]:
+ raise StopIteration()
Review Comment:
```suggestion
def iter_dataset_aliases(self) -> Iterator[DatasetAlias]:
return iter(())
```
I think? Otherwise the error is raised too early.
```pycon
>>> def f1():
... raise StopIteration
...
>>> def f2():
... return iter(())
...
>>> for a in f1(): pass # Wrong
...
Traceback (most recent call last):
File "<python-input-2>", line 1, in <module>
for a in f1(): pass
~~^^
File "<python-input-0>", line 2, in f1
raise StopIteration
StopIteration
>>> for a in f2(): pass # Correct
...
>>>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add DatasetDagRunQueue to all the consuming DAGs of a dataset alias [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #41264:
URL: https://github.com/apache/airflow/pull/41264#discussion_r1705338968
##########
airflow/datasets/__init__.py:
##########
@@ -294,6 +297,9 @@ def as_expression(self) -> Any:
def iter_datasets(self) -> Iterator[tuple[str, Dataset]]:
yield self.uri, self
+ def iter_dataset_aliases(self) -> Iterator[DatasetAlias]:
+ raise StopIteration()
Review Comment:
```suggestion
def iter_dataset_aliases(self) -> Iterator[DatasetAlias]:
return iter(())
```
I think? Otherwise the error is raised to early.
```pycon
>>> def f1():
... raise StopIteration
...
>>> def f2():
... return iter(())
...
>>> for a in f1(): pass # Wrong
...
Traceback (most recent call last):
File "<python-input-2>", line 1, in <module>
for a in f1(): pass
~~^^
File "<python-input-0>", line 2, in f1
raise StopIteration
StopIteration
>>> for a in f2(): pass # Correct
...
>>>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add DatasetDagRunQueue to all the consuming DAGs of a dataset alias [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #41264:
URL: https://github.com/apache/airflow/pull/41264#discussion_r1705308958
##########
airflow/datasets/__init__.py:
##########
@@ -336,6 +342,14 @@ def iter_datasets(self) -> Iterator[tuple[str, Dataset]]:
yield k, v
seen.add(k)
+ def iter_dataset_aliases(self) -> Iterator[DatasetAlias]:
+ """Filter dataest aliases in the condition."""
+ for o in self.objects:
+ if isinstance(o, _DatasetAliasCondition):
+ yield DatasetAlias(o.name)
Review Comment:
Indeed, miss this one. Thanks for reminding me. Just removed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add DatasetDagRunQueue to all the consuming DAGs of a dataset alias [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #41264:
URL: https://github.com/apache/airflow/pull/41264#discussion_r1705267718
##########
airflow/datasets/__init__.py:
##########
@@ -336,6 +342,14 @@ def iter_datasets(self) -> Iterator[tuple[str, Dataset]]:
yield k, v
seen.add(k)
+ def iter_dataset_aliases(self) -> Iterator[DatasetAlias]:
+ """Filter dataest aliases in the condition."""
+ for o in self.objects:
+ if isinstance(o, _DatasetAliasCondition):
+ yield DatasetAlias(o.name)
Review Comment:
Since `_DatasetAliasCondition` already implements this yield, the if-else condition does not seem needed? This can just be
```python
for o in self.objects:
yield from o.iter_dataset_aliases()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add DatasetDagRunQueue to all the consuming DAGs of a dataset alias [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #41264:
URL: https://github.com/apache/airflow/pull/41264#discussion_r1705522857
##########
airflow/datasets/__init__.py:
##########
@@ -294,6 +297,9 @@ def as_expression(self) -> Any:
def iter_datasets(self) -> Iterator[tuple[str, Dataset]]:
yield self.uri, self
+ def iter_dataset_aliases(self) -> Iterator[DatasetAlias]:
+ raise StopIteration()
Review Comment:
yep, thanks for pointing it out! I might use the wrong example to test this out 🤦♂️ Just fixed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add DatasetDagRunQueue to all the consuming DAGs of a dataset alias [airflow]
Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv merged PR #41264:
URL: https://github.com/apache/airflow/pull/41264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org