[GitHub] [arrow] andygrove commented on a change in pull request #9099: ARROW-11129: [Rust][DataFusion] Use tokio for loading parquet

[GitBox <gi...@apache.org>]

andygrove commented on a change in pull request #9099:
URL: https://github.com/apache/arrow/pull/9099#discussion_r552010480



##########
File path: rust/datafusion/src/physical_plan/parquet.rs
##########
@@ -256,16 +257,21 @@ impl ExecutionPlan for ParquetExec {
         let projection = self.projection.clone();
         let batch_size = self.batch_size;
 
-        thread::spawn(move || {
-            if let Err(e) = read_files(
+        task::spawn_blocking(move || {
+            read_files(
                 &filenames,
                 projection.clone(),
                 batch_size,
                 response_tx.clone(),
-            ) {
-                println!("Parquet reader thread terminated due to error: {:?}", e);
-            }
-        });
+            )
+        })
+        .await

Review comment:
       I don't think we want to `await` here for the task to complete?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org