You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Marco Risaliti (JIRA)" <ji...@apache.org> on 2009/06/10 22:27:07 UTC

[jira] Created: (OFBIZ-2589) New Shipment Gateway Config entities

New Shipment Gateway Config entities
------------------------------------

                 Key: OFBIZ-2589
                 URL: https://issues.apache.org/jira/browse/OFBIZ-2589
             Project: OFBiz
          Issue Type: Improvement
          Components: product
    Affects Versions: SVN trunk
            Reporter: Marco Risaliti
            Assignee: Marco Risaliti
            Priority: Minor
             Fix For: SVN trunk


Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2589) New Shipment Gateway Config entities

Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718657#action_12718657 ] 

David E. Jones commented on OFBIZ-2589:
---------------------------------------

I haven't tried to run this, but it's looking good Marco.

> New Shipment Gateway Config entities
> ------------------------------------
>
>                 Key: OFBIZ-2589
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2589
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShipmentGatewayConfig.patch
>
>
> Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2589) New Shipment Gateway Config entities

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897333#action_12897333 ] 

Jacques Le Roux commented on OFBIZ-2589:
----------------------------------------

Thanks Adam,

Sorry for you, it avoid me this useless "lot of work". I will see though if it's worth to continue Marco's work, I can't believe 115 kb of work is totally useless...



> New Shipment Gateway Config entities
> ------------------------------------
>
>                 Key: OFBIZ-2589
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2589
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShipmentGatewayConfig.patch, ShipmentGatewayConfig2.patch
>
>
> Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2589) New Shipment Gateway Config entities

Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2589:
----------------------------------

    Attachment: ShipmentGatewayConfig2.patch

Updated patch. 

> New Shipment Gateway Config entities
> ------------------------------------
>
>                 Key: OFBIZ-2589
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2589
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShipmentGatewayConfig.patch, ShipmentGatewayConfig2.patch
>
>
> Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2589) New Shipment Gateway Config entities

Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924076#action_12924076 ] 

Adam Heath commented on OFBIZ-2589:
-----------------------------------

It is rather useless.  Nothing reads the values in the database.  None of the shipment integration code does.  Having these config screens in the web backends makes one thing that they actually drive code.  So, after spending tons of time to configure them, you find out that the shipment services still end up reading the property file for their data.  That means this feature has wasted my time.

Much work was done to actually figure out what settings each class is fetching from the property file; that's good.  The entities themselves look like they would provide was is needed.  It's just that none of the java code was ever modified to query such data.



> New Shipment Gateway Config entities
> ------------------------------------
>
>                 Key: OFBIZ-2589
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2589
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShipmentGatewayConfig.patch, ShipmentGatewayConfig2.patch
>
>
> Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2589) New Shipment Gateway Config entities

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924159#action_12924159 ] 

Jacques Le Roux commented on OFBIZ-2589:
----------------------------------------

Thanks Adam,

So it's an incomplete WIP, right?

> New Shipment Gateway Config entities
> ------------------------------------
>
>                 Key: OFBIZ-2589
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2589
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShipmentGatewayConfig.patch, ShipmentGatewayConfig2.patch
>
>
> Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-2589) New Shipment Gateway Config entities

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924161#action_12924161 ] 

Jacques Le Roux commented on OFBIZ-2589:
----------------------------------------

Ha sorry,

I did not look at the workflow (using All tab) and as Marco did not clearly wrote that it has been commited at r796874, did not clearly understand what was happening here. Now I understand you reopened it, and why.

> New Shipment Gateway Config entities
> ------------------------------------
>
>                 Key: OFBIZ-2589
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2589
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShipmentGatewayConfig.patch, ShipmentGatewayConfig2.patch
>
>
> Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-2589) New Shipment Gateway Config entities

Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti updated OFBIZ-2589:
----------------------------------

    Attachment: ShipmentGatewayConfig.patch

First patch to support new Shipment Gateway Config entities.

> New Shipment Gateway Config entities
> ------------------------------------
>
>                 Key: OFBIZ-2589
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2589
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShipmentGatewayConfig.patch
>
>
> Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (OFBIZ-2589) New Shipment Gateway Config entities

Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Heath reopened OFBIZ-2589:
-------------------------------


This is not done.  While  there are entities now, there is no way to know if they are actually correct.  Nothing in the system actually uses any of these changes.  This is extremely confusing, when you see entity definitions, and config screens, and you go to a lot of work to configure them all, then find that all your work isn't used.

> New Shipment Gateway Config entities
> ------------------------------------
>
>                 Key: OFBIZ-2589
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2589
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShipmentGatewayConfig.patch, ShipmentGatewayConfig2.patch
>
>
> Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-2589) New Shipment Gateway Config entities

Posted by "Marco Risaliti (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-2589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marco Risaliti closed OFBIZ-2589.
---------------------------------

    Resolution: Fixed

Implemented into rev. 796874.

> New Shipment Gateway Config entities
> ------------------------------------
>
>                 Key: OFBIZ-2589
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2589
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShipmentGatewayConfig.patch, ShipmentGatewayConfig2.patch
>
>
> Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.