[GitHub] [spark] vanzin commented on a change in pull request #24465: [SPARK-27575][CORE][YARN] Yarn file-related confs should merge new value with existing value

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #24465: [SPARK-27575][CORE][YARN] Yarn file-related confs should merge new value with existing value
URL: https://github.com/apache/spark/pull/24465#discussion_r279038530
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -217,12 +233,16 @@ private[spark] class SparkSubmit extends Logging {
    */
   private[deploy] def prepareSubmitEnvironment(
       args: SparkSubmitArguments,
-      conf: Option[HadoopConfiguration] = None)
+      conf: Option[HadoopConfiguration] = None,
+      sparkConfOpt: Option[SparkConf] = None)
 
 Review comment:
   Do you need this extra argument? Can't you achieve the same by passing `--conf` arguments in the unit test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org