You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/26 14:10:56 UTC
[GitHub] pnowojski commented on a change in pull request #6926:
[FLINK-10623][e2e] Extended sql-client e2e test with MATCH_RECOGNIZE
pnowojski commented on a change in pull request #6926: [FLINK-10623][e2e] Extended sql-client e2e test with MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/6926#discussion_r228539342
##########
File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamMatchRule.scala
##########
@@ -42,11 +42,13 @@ class DataStreamMatchRule
RelOptRule.convert(logicalMatch.getInput, FlinkConventions.DATASTREAM)
try {
- Class.forName("org.apache.flink.cep.pattern.Pattern")
+ Class
+ .forName("org.apache.flink.cep.pattern.Pattern",
+ false,
+ Thread.currentThread().getContextClassLoader)
} catch {
case ex: ClassNotFoundException => throw new TableException(
- "MATCH RECOGNIZE clause requires flink-cep dependency to be present on the classpath.",
- ex)
+ "MATCH RECOGNIZE clause requires flink-cep dependency to be present on the classpath.")
Review comment:
Shouldn't we at least log to original exception?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services