[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #165: [YUNIKORN-203] Set unmanaged queue max resource

[GitBox <gi...@apache.org>]

wilfred-s commented on a change in pull request #165:
URL: https://github.com/apache/incubator-yunikorn-core/pull/165#discussion_r435041305



##########
File path: pkg/common/resources/resources.go
##########
@@ -66,6 +67,16 @@ func NewResourceFromMap(m map[string]Quantity) *Resource {
 	return &Resource{Resources: m}
 }
 
+// Create a new resource from a string.
+// The string must be a json marshalled list of map[string]string.
+func NewResourceFromString(str string) (*Resource, error) {
+	var resMap map[string]string

Review comment:
       I used the wrong format to unmarshal, I had the inner set not the outer set. so yes we should go through the `si.Resource`
   Fixed that in the new commit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org