You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/07/03 11:13:47 UTC
[GitHub] [solr] cpoerschke opened a new pull request #200: LUCENE-8682: remove deprecated WordDelimiterFilter[Factory] classes
cpoerschke opened a new pull request #200:
URL: https://github.com/apache/solr/pull/200
https://issues.apache.org/jira/browse/LUCENE-8682
@romseygeek's Feb 2019 patch applied to past point in repo history and then rebased forward with import related conflict resolved plus small twaks and Solr Reference Guide update too.
The changes affects tests and documentation only so no CHANGES.txt entry and separate SOLR JIRA issue needed here in my opinion, but happy to have either or both if others think that would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #200: LUCENE-8682: remove deprecated WordDelimiterFilter[Factory] classes
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #200:
URL: https://github.com/apache/solr/pull/200#issuecomment-877709189
Converting to draft to match the deprecation process status of the corresponding https://github.com/apache/lucene/pull/202 pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #200: LUCENE-8682: remove deprecated WordDelimiterFilter[Factory] classes
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #200:
URL: https://github.com/apache/solr/pull/200#discussion_r665588229
##########
File path: solr/core/src/test/org/apache/solr/analysis/TestWordDelimiterGraphFilterFactory.java
##########
@@ -207,16 +189,16 @@ public void testCustomTypes() throws Exception {
args.put("splitOnCaseChange", "1");
/* default behavior */
- WordDelimiterFilterFactory factoryDefault = new WordDelimiterFilterFactory(args);
+ WordDelimiterGraphFilterFactory factoryDefault = new WordDelimiterGraphFilterFactory(args);
factoryDefault.inform(loader);
TokenStream ts = factoryDefault.create(whitespaceMockTokenizer(testText));
BaseTokenStreamTestCase.assertTokenStreamContents(ts,
- new String[] { "I", "borrowed", "5", "540000", "400", "00", "at", "25", "interest", "interestrate", "rate" });
+ new String[] { "I", "borrowed", "540000", "5", "400", "00", "at", "25", "interestrate", "interest", "rate" });
Review comment:
Slightly concerning here that we are dependent on order from something that I presume is not order-defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org