You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/03/11 01:00:30 UTC
Re: Review Request 31889: Updated Hooks to fix failure during master
failover.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31889/
-----------------------------------------------------------
(Updated March 10, 2015, 8 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Addressed Nik's comments.
Bugs: MESOS-2463
https://issues.apache.org/jira/browse/MESOS-2463
Repository: mesos
Description
-------
The ExecutorInfo is immutable, and so the environment decoration is deferred
until containerizer launch. The new slaveExecutorHook simply notifies the hook
module of a new executor being launched. The environment decorator hook for
containerizer launch update it's environment variables as gathered from the hook
modules.
Diffs (updated)
-----
include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef
src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d
src/hook/manager.hpp d3729eaca1bf2893cbc94cf62835dafb2d9a22a1
src/hook/manager.cpp 3fd9d5e7f81e3d0ca2aca4091beba4ae555ae7e7
src/slave/containerizer/mesos/containerizer.cpp fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748
src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876
Diff: https://reviews.apache.org/r/31889/diff/
Testing
-------
make check. The master failover tests have not been performed yet.
Thanks,
Kapil Arya
Re: Review Request 31889: Updated Hooks to fix failure during master
failover.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31889/
-----------------------------------------------------------
(Updated March 10, 2015, 8:04 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Addressed Nik's comments.
Bugs: MESOS-2463
https://issues.apache.org/jira/browse/MESOS-2463
Repository: mesos
Description
-------
The ExecutorInfo is immutable, and so the environment decoration is deferred
until containerizer launch. The new slaveExecutorHook simply notifies the hook
module of a new executor being launched. The environment decorator hook for
containerizer launch update it's environment variables as gathered from the hook
modules.
Diffs (updated)
-----
include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef
src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d
src/hook/manager.hpp d3729eaca1bf2893cbc94cf62835dafb2d9a22a1
src/hook/manager.cpp 3fd9d5e7f81e3d0ca2aca4091beba4ae555ae7e7
src/slave/containerizer/mesos/containerizer.cpp fbd1c0a0e5f4f227adb022f0baaa6d2c7e3ad748
src/slave/slave.cpp 364d911b086dfe1f15f76aa3888f99146aa8d876
Diff: https://reviews.apache.org/r/31889/diff/
Testing
-------
make check. The master failover tests have not been performed yet.
Thanks,
Kapil Arya