You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/19 14:27:18 UTC
[GitHub] [incubator-pekko-connectors] mdedetrich opened a new pull request, #108: Publish nightly docs
mdedetrich opened a new pull request, #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108
Taken from pekko-management which is published https://github.com/apache/incubator-pekko-management/blob/main/.github/workflows/publish-nightly.yml#L40-L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #108: Publish nightly docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108#issuecomment-1554803363
> My point is that the scalaVersion used in the build affects which dir that the build files end up. The sbt command used in this build does not specify which scala version to use so the default is used. The default appears to be 2.13 so the target dir will be `target/scala-2.13`. The workflow changes in this PR seem to use `target/scala-2.12`.
Ah I see, in that case I have updated the default Scala version to 2.12 since that is what we seem to use everywhere else. I also checked the github workflows to see if this has any unintended consequences and all seems to be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #108: Publish nightly docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108#discussion_r1199207842
##########
project/Common.scala:
##########
@@ -47,7 +47,7 @@ object Common extends AutoPlugin {
projectInfoVersion := (if (isSnapshot.value) "snapshot" else version.value),
crossVersion := CrossVersion.binary,
crossScalaVersions := Dependencies.ScalaVersions,
- scalaVersion := Dependencies.Scala213,
+ scalaVersion := Dependencies.Scala212,
Review Comment:
I would prefer to use Scala213 as the default. All I'm asking for is that we github workflow uses `target/scala-2.13`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #108: Publish nightly docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108#discussion_r1199289496
##########
project/Common.scala:
##########
@@ -47,7 +47,7 @@ object Common extends AutoPlugin {
projectInfoVersion := (if (isSnapshot.value) "snapshot" else version.value),
crossVersion := CrossVersion.binary,
crossScalaVersions := Dependencies.ScalaVersions,
- scalaVersion := Dependencies.Scala213,
+ scalaVersion := Dependencies.Scala212,
Review Comment:
Okay sure, ill revert this and update pekko management
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #108: Publish nightly docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108#discussion_r1199726618
##########
.github/workflows/publish-nightly.yml:
##########
@@ -31,3 +31,26 @@ jobs:
NEXUS_USER: ${{ secrets.NEXUS_USER }}
NEXUS_PW: ${{ secrets.NEXUS_PW }}
run: sbt +publish
+
+ - name: Build Documentation
+ run: |-
+ sbt docs/paradox unidoc
+
+ # Create directory structure upfront since rsync does not create intermediate directories otherwise
+ - name: Create nightly directory structure
+ run: |-
+ mkdir -p target/nightly-docs/docs/pekko-connectors/${{ github.ref_name }}-snapshot/
+ mv docs/target/paradox/site/main/ target/nightly-docs/docs/pekko-connectors/${{ github.ref_name }}-snapshot/docs
+ mv target/scala-2.13/unidoc target/nightly-docs/docs/pekko-connectors/${{ github.ref_name }}-snapshot/api
Review Comment:
The proper way to solve this issue is via an sbt plugin akin to https://github.com/lightbend/sbt-publish-rsync, there is already an issue on this https://github.com/apache/incubator-pekko/issues/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #108: Publish nightly docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108#discussion_r1199213466
##########
project/Common.scala:
##########
@@ -47,7 +47,7 @@ object Common extends AutoPlugin {
projectInfoVersion := (if (isSnapshot.value) "snapshot" else version.value),
crossVersion := CrossVersion.binary,
crossScalaVersions := Dependencies.ScalaVersions,
- scalaVersion := Dependencies.Scala213,
+ scalaVersion := Dependencies.Scala212,
Review Comment:
main pekko repos default to scala 2.13 - it's only a few like pekko-management that default to 2.12.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #108: Publish nightly docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108#issuecomment-1554726449
My point is that the scalaVersion used in the build affects which dir that the build files end up. The sbt command used in this build does not specify which scala version to use so the default is used. The default appears to be 2.13 so the target dir will be `target/scala-2.13`. The workflow changes in this PR seem to use `target/scala-2.12`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin merged pull request #108: Publish nightly docs
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #108: Publish nightly docs
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108#discussion_r1199723670
##########
.github/workflows/publish-nightly.yml:
##########
@@ -31,3 +31,26 @@ jobs:
NEXUS_USER: ${{ secrets.NEXUS_USER }}
NEXUS_PW: ${{ secrets.NEXUS_PW }}
run: sbt +publish
+
+ - name: Build Documentation
+ run: |-
+ sbt docs/paradox unidoc
+
+ # Create directory structure upfront since rsync does not create intermediate directories otherwise
+ - name: Create nightly directory structure
+ run: |-
+ mkdir -p target/nightly-docs/docs/pekko-connectors/${{ github.ref_name }}-snapshot/
+ mv docs/target/paradox/site/main/ target/nightly-docs/docs/pekko-connectors/${{ github.ref_name }}-snapshot/docs
+ mv target/scala-2.13/unidoc target/nightly-docs/docs/pekko-connectors/${{ github.ref_name }}-snapshot/api
Review Comment:
Maybe we can define a variable in YAML for `defaultScalaVersion`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #108: Publish nightly docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108#issuecomment-1554718690
> Is it possible that this project builds with scala-2.13 by default unlike pekko-management -
>
> https://github.com/apache/incubator-pekko-connectors/blob/bd0e1a9506bb29c08f8395bbf11b23ef9c7e709a/project/Common.scala#L50
Aside from consistency, I don't think the default version matters that much anymore at least ever since https://github.com/apache/incubator-pekko/pull/281 and https://github.com/apache/incubator-pekko/pull/257 have been merged and propagated through the various Pekko modules.
We can make a decision on which default version of Scala should be used within our projects (I would opt for 2.13)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #108: Publish nightly docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108#issuecomment-1554691911
Is it possible that this project builds with scala-2.13 by default unlike pekko-management - https://github.com/apache/incubator-pekko-connectors/blob/bd0e1a9506bb29c08f8395bbf11b23ef9c7e709a/project/Common.scala#L50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #108: Publish nightly docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #108:
URL: https://github.com/apache/incubator-pekko-connectors/pull/108#discussion_r1199290781
##########
project/Common.scala:
##########
@@ -47,7 +47,7 @@ object Common extends AutoPlugin {
projectInfoVersion := (if (isSnapshot.value) "snapshot" else version.value),
crossVersion := CrossVersion.binary,
crossScalaVersions := Dependencies.ScalaVersions,
- scalaVersion := Dependencies.Scala213,
+ scalaVersion := Dependencies.Scala212,
Review Comment:
Done and pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org